From owner-cvs-src@FreeBSD.ORG  Mon Nov  3 10:55:56 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3847F16A53D; Mon,  3 Nov 2003 10:55:56 -0800 (PST)
Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 66BDD43FBF; Mon,  3 Nov 2003 10:55:55 -0800 (PST)
	(envelope-from brdavis@odin.ac.hmc.edu)
Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain
	[127.0.0.1])
	by odin.ac.hmc.edu (8.12.9/8.12.3) with ESMTP id hA3ItqSA007450;
	Mon, 3 Nov 2003 10:55:52 -0800
Received: (from brdavis@localhost)
	by odin.ac.hmc.edu (8.12.9/8.12.3/Submit) id hA3ItqDJ007449;
	Mon, 3 Nov 2003 10:55:52 -0800
Date: Mon, 3 Nov 2003 10:55:52 -0800
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Hidetoshi Shimokawa <simokawa@FreeBSD.org>
Message-ID: <20031103185552.GC31067@Odin.AC.HMC.Edu>
References: <200311031301.hA3D1Nuu035458@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="VywGB/WGlW4DM4P8"
Content-Disposition: inline
In-Reply-To: <200311031301.hA3D1Nuu035458@repoman.freebsd.org>
User-Agent: Mutt/1.5.4i
X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/firewire if_fwe.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Nov 2003 18:55:57 -0000


--VywGB/WGlW4DM4P8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 03, 2003 at 05:01:23AM -0800, Hidetoshi Shimokawa wrote:
> simokawa    2003/11/03 05:01:23 PST
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/dev/firewire     if_fwe.c=20
>   Log:
>   - Change driver name to fix if_xname breakage in the previous revision.

Sorry about that.

>   - Don't call device_get_unit() twice.

A better solution would be to move the printf below the if_initname call
and use if_printf().  I dislike printfs that start with things like
"if_fwe%d: ".

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--VywGB/WGlW4DM4P8
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/pqS2XY6L6fI4GtQRAsqsAJ9kIyf27ZJ88F5z95XC4IWx5qoSZACdHiDB
j6wA0/PmEvJt5QXIvYYJvHo=
=WL03
-----END PGP SIGNATURE-----

--VywGB/WGlW4DM4P8--