From owner-svn-src-head@freebsd.org Mon Nov 13 02:00:18 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2594BCFC0B4; Mon, 13 Nov 2017 02:00:18 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 03CA37CC0E; Mon, 13 Nov 2017 02:00:17 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id BCEC15A9F12; Mon, 13 Nov 2017 02:00:16 +0000 (UTC) Date: Mon, 13 Nov 2017 02:00:16 +0000 From: Brooks Davis To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, kdrakehp@zoho.com Subject: Re: svn commit: r324619 - in head/usr.bin/procstat: . tests Message-ID: <20171113020016.GF76223@spindle.one-eyed-alien.net> References: <201710141838.v9EIcaOQ047300@repo.freebsd.org> <81c30f82-268e-ce59-4326-5a2f14ca62e5@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Uu2n37VG4rOBDVuR" Content-Disposition: inline In-Reply-To: <81c30f82-268e-ce59-4326-5a2f14ca62e5@FreeBSD.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 02:00:18 -0000 --Uu2n37VG4rOBDVuR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 12, 2017 at 12:15:35PM +0200, Andriy Gapon wrote: > On 14/10/2017 21:38, Brooks Davis wrote: > > Author: brooks > > Date: Sat Oct 14 18:38:36 2017 > > New Revision: 324619 > > URL: https://svnweb.freebsd.org/changeset/base/324619 > >=20 > > Log: > > Switch procstat from subcommand flags to verbs > > =20 > > - Use an enumerated value instead of separate flags for commands > > - Look for a verb if no command flag is set > > - Lookup the "xocontainer" value based on the command > > - Document the new command verbs in the man-page > > =20 > > Submitted by: kdrakehp@zoho.com > > Differential Revision: https://reviews.freebsd.org/D10916 >=20 > What's the new way of doing procstat -kk -a ? >=20 > procstat -kk -a now crashes because cmd is NULL when 'k' option is proces= sed. > procstat kstack and procstat kstack -v just produce the usage message wit= hout > telling any specific usage error. > procstat kstack -a says that 'a' is an illegal option. =46rom the reading the manpage it should be: procstat -a kstack -v The crash is a regression. Please file a bugreport. -- Brooks --Uu2n37VG4rOBDVuR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJaCPyvAAoJEKzQXbSebgfAFOIIAIqKB/sv+NO7FPIXtuwPGxCT s+Hfh695iRigN4s9Puksvkws5q84o2hPFIoYZC8XkjhIhOvqqQTDtoi/Q3WCZZhb e6jvbQeeMuYnrCQp3707Le+3maJRTt1TAVvtrBImVZEGN1SI5vE7KJReBHLvyU7N Mc6YDTBi3/V2HJ8y5X5sBCdnkYZBw42f79WfsX2aoi1grcloymWcSfxptZwzqemq t4IpghVtrb2RlO912aU8wtq7EpfdaLEaP/NbPPuykcSBntBfyVdFeXQNbE7CN4nz K0HDtsnQWK6QJe7eyh8EP6pptSqzQ1Oe9TbLrQFiZbX/tau9y8L+xo+opSkQe2c= =Pi0j -----END PGP SIGNATURE----- --Uu2n37VG4rOBDVuR--