Date: Fri, 06 Sep 2019 22:47:17 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240375] [NEW PORT] www/py-isso: A commenting server similar to Disqus Message-ID: <bug-240375-7788-lHCk15bMRj@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240375-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-240375-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240375 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |python@FreeBSD.org, | |rt@scientifics.de Flags| |maintainer-feedback?(rt@sci | |entifics.de) Keywords| |feature, needs-patch, | |needs-qa Status|New |Open --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- Thank you for your new port submission Ren=C3=A9 There's a number of review items that need to be taken care of, so it would= be great if you could run the port through QA (portlint, and poudriere in particular).=20 For more details and instructions see: https://www.freebsd.org/doc/en/books/porters-handbook/testing.html At a quick glance: - Remove "A " from COMMENT (portlint should complaint about this) - COMMENT for Python ports should match setup.py:description with portlint compliant changes where necessary (COMMENT=3DLightweight Disqus alternative) - Use GH_* variables (eg: GH_TAGNAME) not COMMIT_ID - Use MASTER_SITES=3DCHEESESHOP unless there is a compelling temporary reas= on to use an alternative source (like GitHub), such as missing test or test data files. - Add python as a secondary CATEGORIES - NO_ARCH is out of order (put it after USES, portlint should complain about this) - Dont hardcode paths (like /usr/local/etc), as people can change their PRE= FIX. Use ${ETCDIR} instead) - cffi is missing as a BUILD_DEPENDS (setup_requires=3D["cffi>=3D1.3.0"],) - conditional Python 2.7 dependencies are missing (':python_version=3D=3D"2= .7"': ['ipaddr>=3D2.1', 'configparser']) - Note: these should be moved in upstrea= m code to install_requires with environment markers, they are not optional for python2.7) - For all *_DEPENDS, match the version specifiers are closely as possible. RUN_DEPENDS currently specify >0, but setup.py says, for example: misaka>=3D2.0,<3.0' werkzeug>=3D0.9 ipaddr>=3D2.1' --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240375-7788-lHCk15bMRj>