Date: Wed, 19 Apr 2017 16:53:25 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316978 - in head: contrib/zstd etc/mtree lib lib/libzstd share/mk usr.bin usr.bin/zstd Message-ID: <20170419145325.zjvo3hq2z3egcp26@ivaldir.net> In-Reply-To: <20170419142106.GA59031@bsdpad.com> References: <201704152005.v3FK5M2j002459@repo.freebsd.org> <20170419142106.GA59031@bsdpad.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--mefsnsm53xpgretk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2017 at 02:21:06PM +0000, Ruslan Bukin wrote: > This break RISC-V world build: > /home/br/obj//riscv.riscv64/usr/home/br/dev/freebsd-head/tmp/usr/lib/libp= rivatezstd.so: undefined reference to `__bswap > si2' > /home/br/obj//riscv.riscv64/usr/home/br/dev/freebsd-head/tmp/usr/lib/libp= rivatezstd.so: undefined reference to `__bswap > di2' >=20 > Here is patch that makes it compilable: >=20 > diff --git a/contrib/zstd/lib/common/xxhash.c b/contrib/zstd/lib/common/x= xhash.c > index eb44222c5fc..d59a22a0638 100644 > --- a/contrib/zstd/lib/common/xxhash.c > +++ b/contrib/zstd/lib/common/xxhash.c > @@ -206,7 +206,7 @@ static U64 XXH_read64(const void* memPtr) > #if defined(_MSC_VER) /* Visual Studio */ > # define XXH_swap32 _byteswap_ulong > # define XXH_swap64 _byteswap_uint64 > -#elif GCC_VERSION >=3D 403 > +#elif (GCC_VERSION >=3D 403 && !defined(__riscv__)) > # define XXH_swap32 __builtin_bswap32 > # define XXH_swap64 __builtin_bswap64 > #else >=20 > Ruslan Thank you, can you please commit it? Have you upstreamed it, do you want me= to do it? (I have already signed the facebook agreement) Best regards, Bapt --mefsnsm53xpgretk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlj3eeIACgkQY4mL3PG3 Ploygg//T+gs26GtRD54jUx/CnUKZTjisQwKHHFB1KdnK2Pi+L5auL+drZdHOUw3 9hnYLglz2zxsZ2fY47VQKDKVyBemi0fUd/Xuc0jVNaKCikUWMCr9vUk89kF9coWJ wxtr8ARiSv8KpILz9NlzdvmJR7DjLd1P2qDfRMHWWBCSOcl3mNoO99rRmr3q7q9l LMbN/GJlwEYj80eK0XT96Ysstzojp3pBn6hf2jueHxehXMRyQY+E7ovM7JithiEI aOX17SyBJlorcWalprz9IXo6Z3wjmFaSbvBv5vBE7xQypQru5zJQd7wnDwmTQ7kr NneO+gjN9OFar8+Eu5B8ko5KYkBXdk4rw1ltL6XBNzeVj0eGPFgH5xs5XpcMUM7w 6fInLmc136q9u0Qiq6B3uxRpv9ENUgGzSSLHIIOtzz/F4zOrxWjLO7QPb2dFZAj4 FTtIbhGGFMzBz7ic3PGVJmSdW7qhd36WlFmaV6lVtSQkLxIBTdneAOmoGSeU+MAu 97q2G5FJOPoQ8PHKsahDEaw/rtmi+BWUcZFzy+srWjio6zH8wW8FTkioP0qOTYMi teNk11Qk5P40nIYJg08zPN42XjChp9Nli6JEGPMY6i6LNKoOp+ztpUh22zGxu4HU JX7IKXWfpfJ9FrfgZCUSJSlIJ+qjSjGT5N7QG3ddJBQBR7omOq8= =jo56 -----END PGP SIGNATURE----- --mefsnsm53xpgretk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170419145325.zjvo3hq2z3egcp26>