From owner-freebsd-current@FreeBSD.ORG Sat Oct 12 19:42:19 2013 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4C961D4; Sat, 12 Oct 2013 19:42:19 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B9D582DC9; Sat, 12 Oct 2013 19:42:18 +0000 (UTC) Received: from alph.d.allbsd.org (p4181-ipbf1307funabasi.chiba.ocn.ne.jp [123.225.173.181]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r9CJg0el099188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 13 Oct 2013 04:42:10 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.7/8.14.5) with ESMTP id r9CJfxf9093932; Sun, 13 Oct 2013 04:42:00 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 13 Oct 2013 04:40:58 +0900 (JST) Message-Id: <20131013.044058.1382656329747589715.hrs@allbsd.org> To: current@FreeBSD.org Subject: Problems with rc.d/jail change (Re: svn commit: r256256 - in head: . etc etc/defaults etc/rc.d share/man/man5 usr.sbin/jail) From: Hiroki Sato In-Reply-To: <4B2ECC28-4F63-448A-B99E-DC5215C5FFD0@freebsd.org> References: <20131011141214.GA91989@mouf.net> <4B2ECC28-4F63-448A-B99E-DC5215C5FFD0@freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 13 Oct 2013 04:42:10 +0900 (JST) X-Spam-Status: No, score=-97.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: swills@FreeBSD.org, remko@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 19:42:19 -0000 ----Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)-- Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Oct_13_04_40_58_2013_119)--" Content-Transfer-Encoding: 7bit ----Next_Part(Sun_Oct_13_04_40_58_2013_119)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Remko Lodder wrote in <4B2ECC28-4F63-448A-B99E-DC5215C5FFD0@freebsd.org>: re> re> On Oct 11, 2013, at 4:12 PM, Steve Wills wrote: re> re> > I'm having the same issue. re> re> I am working with Hiroki to resolve this. So far his work seems to fix re> this, he will commit that as soon as we can reasonable think re> that this is OK (and it looks that way :)) Let me summarize what I noticed so far: (1) A jail with jail_fdescfs_enable="YES" fails to start. (2) A jail with multiple parameters in jail_parameters="..." fails to start. (1) was fixed in r256385. The attached patch should fix (2). Please try it if you still have a problem. Jail configurations can be complex, so there may be some more cases which break the old behaviors. Please send me your report if you have differences between before and after the rc.d/jail change. -- Hiroki ----Next_Part(Sun_Oct_13_04_40_58_2013_119)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="jail_20131013-1.diff" Index: etc/rc.d/jail =================================================================== --- etc/rc.d/jail (revision 256385) +++ etc/rc.d/jail (working copy) @@ -94,7 +94,7 @@ # parse_options() { - local _j + local _j _p _j=$1 _confwarn=0 @@ -234,7 +234,9 @@ "\"procfs ${_rootdir%/}/proc procfs rw 0 0\";" fi - echo " ${_parameters};" + for _p in $_parameters; do + echo " ${_p%\;};" + done eval : \${jail_${_j}_mount_enable:=${jail_mount_enable:-NO}} if checkyesno jail_${_j}_mount_enable; then ----Next_Part(Sun_Oct_13_04_40_58_2013_119)---- ----Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlJZpcoACgkQTyzT2CeTzy3EsACfX+GXWCd2KLwXnY81fpLJAyDv dvQAoLHiNhZtA1zFWHbmqCOTCzkGtK/m =OsnO -----END PGP SIGNATURE----- ----Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)----