From owner-svn-ports-head@FreeBSD.ORG Thu Mar 19 23:03:04 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9066A96; Thu, 19 Mar 2015 23:03:04 +0000 (UTC) Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 638A2845; Thu, 19 Mar 2015 23:03:04 +0000 (UTC) Received: by wegp1 with SMTP id p1so69218909weg.1; Thu, 19 Mar 2015 16:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=aqaDcFdAIhPgFe3N2hwMoRlpLyGKSKq/0o/4Jhzal7I=; b=UnOodD7Ar5WlxFyi6vU+xj8LcIqxYikGeIm6Faq3olfP+dAvTSE/bFq1kGWth8462p nLzM4cwVANCUvrLdFftE0u5VzIVRr/v+ghsn/zSt0zd4HB5fR95C2YGOwDVxCsil4D8V lvx+lJMi/vMhxGkq3Pw6LI4wAc4xd2c29Py+o6CNXsS5kbWeR2QxhNSAV85Fv8sYId5G MgHqXvmN0gEpyJ0XfPc9q6RFX7CP0OM1twVeEyyVJybAkiwbDjluJEsGtaRXc3idOUzv U8yCjc/7EP3glbNopyFMKEtdnufqs0RzOTD+/OIpJxEEZ2hq5g7UZVou1E8m0iVLTwvD 23jQ== X-Received: by 10.180.87.165 with SMTP id az5mr20120793wib.29.1426806182323; Thu, 19 Mar 2015 16:03:02 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id q10sm3833010wjr.41.2015.03.19.16.03.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 16:03:01 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 20 Mar 2015 00:02:59 +0100 From: Baptiste Daroussin To: Bryan Drewery Subject: Re: svn commit: r381680 - in head/x11-fonts: font-sun-misc font-winitzki-cyrillic font-xfree86-type1 Message-ID: <20150319230259.GC50017@ivaldir.etoilebsd.net> References: <201503191940.t2JJevIZ034555@svn.freebsd.org> <550B2916.3090401@FreeBSD.org> <20150319220658.GB50017@ivaldir.etoilebsd.net> <550B51F1.1010608@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6zdv2QT/q3FMhpsV" Content-Disposition: inline In-Reply-To: <550B51F1.1010608@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, Antoine Brodin , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 23:03:05 -0000 --6zdv2QT/q3FMhpsV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 19, 2015 at 05:47:13PM -0500, Bryan Drewery wrote: > On 3/19/2015 5:06 PM, Baptiste Daroussin wrote: > > On Thu, Mar 19, 2015 at 02:52:54PM -0500, Bryan Drewery wrote: > >> On 3/19/2015 2:40 PM, Antoine Brodin wrote: > >>> Author: antoine > >>> Date: Thu Mar 19 19:40:56 2015 > >>> New Revision: 381680 > >>> URL: https://svnweb.freebsd.org/changeset/ports/381680 > >>> QAT: https://qat.redports.org/buildarchive/r381680/ > >>> > >>> Log: > >>> Add missing BUILD_DEPENDS and CONFIGURE_ARGS > >>> > >>> Modified: > >>> head/x11-fonts/font-sun-misc/Makefile > >>> head/x11-fonts/font-winitzki-cyrillic/Makefile > >>> head/x11-fonts/font-xfree86-type1/Makefile > >>> > >>> Modified: head/x11-fonts/font-sun-misc/Makefile > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/x11-fonts/font-sun-misc/Makefile Thu Mar 19 19:38:48 2015 (r= 381679) > >>> +++ head/x11-fonts/font-sun-misc/Makefile Thu Mar 19 19:40:56 2015 (r= 381680) > >>> @@ -4,15 +4,18 @@ > >>> PORTNAME=3D font-sun-misc > >>> PORTVERSION=3D 1.0.3 > >>> PORTREVISION=3D 2 > >>> -MASTER_SITES=3D XORG > >>> -MASTER_SITE_SUBDIR=3D individual/font > >>> +MASTER_SITES=3D XORG/individual/font > >>> CATEGORIES=3D x11-fonts > >>> =20 > >>> MAINTAINER=3D x11@FreeBSD.org > >>> COMMENT=3D X.Org miscellaneous Sun fonts > >>> =20 > >>> +BUILD_DEPENDS=3D bdftopcf:${PORTSDIR}/x11-fonts/bdftopcf \ > >>> + mkfontdir:${PORTSDIR}/x11-fonts/mkfontdir > >>> + > >>> USES=3D fonts tar:bzip2 > >>> FONTNAME=3D misc > >>> GNU_CONFIGURE=3D yes > >>> +CONFIGURE_ARGS=3D --with-fontrootdir=3D${PREFIX}/lib/X11/fonts > >>> =20 > >> > >> How is this an improvement over XORG_CAT? There's like 6 more lines th= an > >> before. > >> > >> Should those BUILD_DEPENDS be in fonts.mk? > >=20 > > The improvement is in the fact that XORG_CAT is doing wrong things with= fonts, > > while fonts.mk is not. > >=20 > > Sure I can add an argument to fonts.mk to reduce avoid duplicating thin= gs > >=20 > > Best regards, > > Bapt > >=20 >=20 > Why not fix XORG_CAT? >=20 Because XORG_CAT only works with xorg's fonts not for all fonts while with fonts.mk we can have the same behavious for all fonts (the others fonts are wrong as well) Best regards, Bapt --6zdv2QT/q3FMhpsV Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlULVaMACgkQ8kTtMUmk6EzFGACgshcfwAFFvk6fGAt2jv1r3xcG t6EAn30TBT9nk1WWzFm42JmOfD0TTOze =IFRL -----END PGP SIGNATURE----- --6zdv2QT/q3FMhpsV--