From owner-p4-projects@FreeBSD.ORG  Fri Aug 31 23:13:02 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B17FF16A41A; Fri, 31 Aug 2007 23:13:02 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 424CF16A468
	for <perforce@FreeBSD.org>; Fri, 31 Aug 2007 23:13:02 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 3336913C480
	for <perforce@FreeBSD.org>; Fri, 31 Aug 2007 23:13:02 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7VND2Ck009638
	for <perforce@FreeBSD.org>; Fri, 31 Aug 2007 23:13:02 GMT
	(envelope-from cnst@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7VND1pw009635
	for perforce@freebsd.org; Fri, 31 Aug 2007 23:13:01 GMT
	(envelope-from cnst@FreeBSD.org)
Date: Fri, 31 Aug 2007 23:13:01 GMT
Message-Id: <200708312313.l7VND1pw009635@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	cnst@FreeBSD.org using -f
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 125916 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Aug 2007 23:13:03 -0000

http://perforce.freebsd.org/chv.cgi?CH=125916

Change 125916 by cnst@dale on 2007/08/31 23:12:30

	remove redundant comment and thread_lock/thread_unlock from stock CVS coretemp(4)

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#7 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#7 (text+ko) ====

@@ -221,25 +221,13 @@
 	if (smp_cpus > 1) {
 		thread_lock(curthread);
 		sched_bind(curthread, cpu);
+		msr = rdmsr(MSR_THERM_STATUS);
+		sched_unbind(curthread);
 		thread_unlock(curthread);
 	} else if (cpu != 0)
 		return (-1);
-
-	/*
-	 * The digital temperature reading is located at bit 16
-	 * of MSR_THERM_STATUS.
-	 *
-	 * There is a bit on that MSR that indicates whether the
-	 * temperature is valid or not.
-	 *
-	 * The temperature is computed by subtracting the temperature
-	 * reading by Tj(max).
-	 */
-	msr = rdmsr(MSR_THERM_STATUS);
-
-	thread_lock(curthread);
-	sched_unbind(curthread);
-	thread_unlock(curthread);
+	else
+		msr = rdmsr(MSR_THERM_STATUS);
 
 	/*
 	 * Check for Thermal Status and Thermal Status Log.