From owner-dev-commits-src-all@freebsd.org Sat Jul 10 19:34:58 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A394265A741; Sat, 10 Jul 2021 19:34:58 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GMgGV3QMXz4mPk; Sat, 10 Jul 2021 19:34:58 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 313F826028D; Sat, 10 Jul 2021 21:34:51 +0200 (CEST) Subject: Re: git: d038463bd269 - main - Make sure the XHCI driver obeys the isochronous scheduling threshold value as given by the XHCI hardware parameters to avoid scheduling isochronous transfers too early. To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202107101904.16AJ4lj3035432@gitrepo.freebsd.org> <09444339-973B-4A2B-ACEA-B00B8E48F460@freebsd.org> From: Hans Petter Selasky Message-ID: <4a0de77e-babe-8fd7-502e-df3dbb309616@selasky.org> Date: Sat, 10 Jul 2021 21:34:43 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <09444339-973B-4A2B-ACEA-B00B8E48F460@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4GMgGV3QMXz4mPk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jul 2021 19:34:58 -0000 On 7/10/21 9:30 PM, Jessica Clarke wrote: > This broke amd64 GENERIC with error: use of undeclared identifier ‘sc' > > Should this be temp.sc? Yes. I was testing mostly with GENERIC-NODEBUG and forgot to check all the prints. Fixed: https://cgit.freebsd.org/src/commit/?id=f52783fcf5cc60734121d061beef0d4ea47b224a --HPS