From owner-freebsd-perl@FreeBSD.ORG Mon Jul 7 16:27:38 2014 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1ACAC75D; Mon, 7 Jul 2014 16:27:38 +0000 (UTC) Received: from exodus.zi0r.com (exodus.zi0r.com [71.179.14.195]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "exodus.zi0r.com", Issuer "Gandi Standard SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B588226AF; Mon, 7 Jul 2014 16:27:37 +0000 (UTC) Received: from exodus.zi0r.com (localhost [127.0.0.1]) by exodus.zi0r.com (Postfix) with ESMTP id C8E173A09D; Mon, 7 Jul 2014 12:27:36 -0400 (EDT) X-Virus-Scanned: amavisd-new at zi0r.com Received: from exodus.zi0r.com ([127.0.0.1]) by exodus.zi0r.com (exodus.zi0r.com [127.0.0.1]) (amavisd-new, port 10026) with LMTP id CwNG6RmcE93i; Mon, 7 Jul 2014 12:27:36 -0400 (EDT) Received: from exodus.zi0r.com (syn.zi0r.com [71.179.14.194]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by exodus.zi0r.com (Postfix) with ESMTPSA id 076453A09A; Mon, 7 Jul 2014 12:27:36 -0400 (EDT) Date: Mon, 7 Jul 2014 12:27:34 -0400 From: Ryan Steinmetz To: Baptiste Daroussin Subject: Re: p5-Git-Repository Message-ID: <20140707162734.GC74596@exodus.zi0r.com> References: <53BA9AD8.7030906@myarcher.net> <20140707134409.GA12289@exodus.zi0r.com> <20140707161318.GB74596@exodus.zi0r.com> <20140707161913.GB97203@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20140707161913.GB97203@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Mathieu Arnold , Barrie Archer , perl@freebsd.org, portmgr@freebsd.org X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2014 16:27:38 -0000 On (07/07/14 18:19), Baptiste Daroussin wrote: >On Mon, Jul 07, 2014 at 12:13:18PM -0400, Ryan Steinmetz wrote: >> >> On (07/07/14 17:55), Mathieu Arnold wrote: >> >+--On 7 juillet 2014 09:44:09 -0400 Ryan Steinmetz wrote: >> >| We should either add workarounds for older systems or a warning >> >| that will be printed if a user is running a FreeBSD release that lacks >> >| required functionality for the ports tree to function. >> > >> >Well, the ports tree is only guaranteed to work with supported FreeBSD >> >releases. So, if you're not running a supported release, you're on your own. >> > >> >We can't add bits and pieces of version checks around everything that won't >> >work with older releases. >> >> We know what the supported releases are and we can easily add a check >> to the framework to verify that you are running a supported release and >> print a message if not. This would be identical to what was done with >> the PKGNG checks/warnings. >> >> The goal is to give the user a useful message ("You are using an >> unsupported version, please upgrade.") versus the errors that Barrie ran >> into ("Unknown modifier 't'" or "make: fatal errors encountered -- cannot continue"). > >Except that is that case it is impossible to catch it reliably, some impossible >to warn about it. We don't need to catch anything. We simply need: .if (${OSVERSION} >= 902510 && ${OSVERSION} < 1000000) || ${OSVERSION} >= 1000704 ${ECHO} "You are using an unsupported release. The ports tree may not function correctly. Please update to a supported release for the best experience. See http://.....freebsd.org/... for a list of supported releases. .endif Obviously the versions are not correct, but, again, the goal is to give people something to work with. Just like what we did with the PKGNG warnings. -r > >regards, >Bapt -- Ryan Steinmetz PGP: 9079 51A3 34EF 0CD4 F228 EDC6 1EF8 BA6B D028 46D7