From owner-freebsd-current@freebsd.org Wed Aug 14 18:08:03 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8EA4B51CE for ; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467yHR43cKz3Dcc for ; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 87C25B51CD; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 87665B51CA; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467yHR30rzz3DcZ; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 1923E19FBC; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-wm1-f52.google.com with SMTP id o4so73308wmh.2; Wed, 14 Aug 2019 11:08:03 -0700 (PDT) X-Gm-Message-State: APjAAAUFECI+AYpCOjlVz7CWkwNd1H+Sv2NgOIbiZqtFi50x8KyXMHBa ycw/0uj1ziG2txFLEYAntnZLtUfbwZGAjrZ8PxI= X-Google-Smtp-Source: APXvYqyak8MfNpCQepUwGOKhNsO5G6MUb96PyMO2NKGm9Z+60XAMNUa8Ut5utBEtK7NplZdRW0TTheNUpLyyS5lb2I0= X-Received: by 2002:a1c:4087:: with SMTP id n129mr387517wma.3.1565806081949; Wed, 14 Aug 2019 11:08:01 -0700 (PDT) MIME-Version: 1.0 References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> In-Reply-To: From: Kyle Evans Date: Wed, 14 Aug 2019 13:06:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore Cc: Niclas Zeising , Emmanuel Vadot , John Baldwin , x11@freebsd.org, current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:08:03 -0000 On Wed, Aug 14, 2019 at 1:04 PM Ian Lepore wrote: > > On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: > > On 2019-08-14 19:23, Emmanuel Vadot wrote: > > > On Wed, 14 Aug 2019 10:13:48 -0700 > > > John Baldwin wrote: > > > > > > > On 8/14/19 9:22 AM, Ian Lepore wrote: > > > > > This all sounds vaguely wrong, backwards, to me. A developer > > > > > who is > > > > > using a given module on their build system might want that > > > > > module to be > > > > > rebuilt automatically, but only if the build parameters match > > > > > those of > > > > > the running build host system. > > > > > > > > > > If my build host is running freebsd 12 amd64 and I'm doing a > > > > > build for > > > > > freebsd 13 armv7, I have no interest in automatic rebuilds of > > > > > an amd64 > > > > > driver module for a different OS arch and version just because > > > > > that > > > > > module happens to be installed on the system I use to do > > > > > crossbuilds. > > > > > > > > > > My objections are theoretical... this automation just seems > > > > > improperly > > > > > designed to me. But it won't actually affect me in any way, > > > > > because I > > > > > don't build video driver modules from ports, and I don't run > > > > > freebsd > > > > > current on my build host machine. Probably the number of > > > > > people doing > > > > > crossbuilding is small enough that nobody else is going to > > > > > object to > > > > > this "the whole world is amd64" automation. > > > > > > > > You assume DRM is amd64-only when it is definitely not. It also > > > > has > > > > suitable guards in its Makefile to only build the relevant kernel > > > > modules on supported architectures. > > > > > > I clearly don't want to spend time to build the drm and radeon > > > modules > > > when I'm hacking on arm64. > > > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > > > subdirectory ? So when you install drm-kmod-* it will only install > > > the > > > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or > > > whatever > > > the correct dir is). > > > > > > > I'm not sure what you're trying to accomplish. I might be > > misunderstanding completely, but, at least the drm ports have > > safeguards > > in their makefiles so they'll only be built for those arches where > > there > > is support, and only the modules needed, as an example, i915kms.ko > > will > > only be built on amd64 and i386, if that's what you're worried about. > > Regards > > I can't understand what you guys are not-understanding. New machinery > has been added that says "if some module source code exists in this > absolute fixed location on the build machine, then whenever you do any > kernel build for any OS version or any arch, rebuild that module source > code so that the the build machine's video drivers stay in sync with > the build machine's kernel." LOCAL_MODULES="" does seem like a sensible default when we're not building a native kernel.