From owner-cvs-src@FreeBSD.ORG Mon Jul 7 18:27:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB93937B404; Mon, 7 Jul 2003 18:27:39 -0700 (PDT) Received: from skyline.ome.meisei-u.ac.jp (skyline.ome.meisei-u.ac.jp [160.194.0.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 991AB43F85; Mon, 7 Jul 2003 18:27:37 -0700 (PDT) (envelope-from root@skyline.ome.meisei-u.ac.jp) Received: from skyline.ome.meisei-u.ac.jp (localhost [127.0.0.1]) id h681RajF049256; Tue, 8 Jul 2003 10:27:36 +0900 (JST) Received: (from root@localhost)h681Ra3q049255; Tue, 8 Jul 2003 10:27:36 +0900 (JST) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) h6812M4L019390 for ; Tue, 8 Jul 2003 10:02:22 +0900 (JST) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 2C24A56FEB; Mon, 7 Jul 2003 18:02:18 -0700 (PDT) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id EBFA837B417; Mon, 7 Jul 2003 18:02:11 -0700 (PDT) Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E3B537B401; Mon, 7 Jul 2003 18:01:59 -0700 (PDT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA08143F85; Mon, 7 Jul 2003 18:01:56 -0700 (PDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id h6811seb018891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Jul 2003 21:01:55 -0400 (EDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id h6811sTT018888; Mon, 7 Jul 2003 21:01:54 -0400 (EDT) (envelope-from wollman) Date: Mon, 7 Jul 2003 21:01:54 -0400 (EDT) From: Garrett Wollman Message-Id: <200307080101.h6811sTT018888@khavrinen.lcs.mit.edu> To: wpaul@freebsd.org (Bill Paul) In-Reply-To: <20030707234511.3B0FB37B401@hub.freebsd.org> References: <200307071845.h67Ij1N1016542@khavrinen.lcs.mit.edu> <20030707234511.3B0FB37B401@hub.freebsd.org> X-Spam-Score: -19.8 () IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES X-Scanned-By: MIMEDefang 2.33 (www . roaringpenguin . com / mimedefang) X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-cvs-all@freebsd.org Errors-To: owner-cvs-all@freebsd.org X-Virus-Scanned: by amavisd-milter (http://amavis.org/) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jul 2003 01:27:40 -0000 < 1) Change vlan_input() to apply EVL_VLANOFTAG() to all incoming tags > (in both hardware and non-hardware tagging cases) and change the > vlan_ioctl() function to only accept vlan tags from 0 to 4095 > and return EINVAL if the caller tries to set any of the other > bits. (Prevent user from shooting self in foot.) I believe that this is the correct choice. (It's probably a result of my stupidity that the vlan driver didn't do this already.) At some point we should do something sensible with the other bits, too. In some applications it might be useful to allow the user to configure the .1p priority bits, outside of a VLAN context. (We should be able to at least decode frames that arrive with .1p encapsulation but .1Q tag 0.) -GAWollman _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"