From nobody Sat Jun 28 20:12:54 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bV3WZ0dqrz60R3P; Sat, 28 Jun 2025 20:12:58 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bV3WY5yv9z40vb; Sat, 28 Jun 2025 20:12:57 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751141577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fqsf2cvSoTsA6feDQQnU3WX/BEC1bQMx3OoK1x4giGQ=; b=HWueNlLantbDTOqYlW8DAQgSMcmUSUFjQNU9EnJFG0MH3edkev5c5NmhMQ1L2SrZSfnxRp VYUVB77blPB7K36Onulh+JizFWUiyfH3aM63hxd2vTiR22L4qs8eBvhRb4tY5wnmRfG/VW zze4WWSlhFYB5Nmh2d6BnBi31uwi7WG/dv0aZu4sxTeWmmE/y/WrHZpN/6DzDRJz65etAH 9ebD4QkaoXTdqh/hWW4riVsDYblcQqK3MxDx5oBWOfXw2CXyOZynjBfq/uNHxfTLmDvaw7 2KWom+ujrWB0ouOWbSx8ZY9nA+PSfbuopvZKRLGzDy8CTa9rU8C4MLqMrNraLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751141577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fqsf2cvSoTsA6feDQQnU3WX/BEC1bQMx3OoK1x4giGQ=; b=pVj4GN691EplyvzmPUO1YcYAzkk0Epb3Y+K978qIl5yDCxDkINMeNS25+yIEat3Vp3nEWL /j2UWd9oGS5VYrx7v3oQO/ieWnp0puVBCz/vEKveqmGkHcIW8lK68I7PcMv6Xr/OjXVLfr f7uPTYaX2i7erBb6F4TOntJPdfHII2Zb6FxxCKbntaEr8UD92kVSxjW8yKPb0mRymHkLa9 hvCnWZG8/97ofyXmQGMqYGp97kTPWuAOuByIo7JfkFjX+ZvaNv351bJq8f1Ep2rwsliiML t/uuw30RKF6b5nZZUjqN6K2dVre6HqVwDI+3VV8B+kk930ZHnb2mzJWJiSt5tQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751141577; a=rsa-sha256; cv=none; b=qdNjH/BjDJibfW51VoDQgU8B29QhdlMEBxj3gezf9VPpl66B44Rc3UpJez5CkuOhqO/QL9 PvRmz7KQL3dG9SiJWGKGDtHoSDFZx5MeH8alljZkQzzOQwgiBOFVscjCVE5svhMFZOUItc mkHh865JcmtQyOg8nDevZmIKIx7EBKz4TV5R7qVRQ/BXVLKh6UHE4bbY+n4IcBURIJfmK3 7MQ3FOlrSRm5MyBPyIjd8n7WOOTHDUENb/9JQZ0MIZG9cwo4HoIFOcJGdcuwhsO9JTd8n5 4YLnONNLQg23dPHgHyG0mWQsww81oPXdIyfBtOPTX5cQdQMjX0LOwZV3CcBWrw== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bV3WY0CL9z12HC; Sat, 28 Jun 2025 20:12:56 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sat, 28 Jun 2025 13:12:54 -0700 From: Gleb Smirnoff To: Michael Tuexen Cc: Charlie Li , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 89f6eb0a61cb - main - tcp: restrict the contents of tcp_timer.h to the kernel context Message-ID: References: <202506261609.55QG9odv049208@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jun 28, 2025 at 04:04:33AM +0200, Michael Tuexen wrote: M> >> + M> >> /* M> >> * The TCPT_REXMT timer is used to force retransmissions. M> >> * The TCP has the TCPT_REXMT timer set whenever segments M> >> @@ -133,8 +135,6 @@ M> >> (tv) = (tvmax); \ M> >> } while(0) M> >> -#ifdef _KERNEL M> >> - M> >> #define TP_KEEPINIT(tp) ((tp)->t_keepinit ? (tp)->t_keepinit : tcp_keepinit) M> >> #define TP_KEEPIDLE(tp) ((tp)->t_keepidle ? (tp)->t_keepidle : tcp_keepidle) M> >> #define TP_KEEPINTVL(tp) ((tp)->t_keepintvl ? (tp)->t_keepintvl : tcp_keepintvl) M> > This broke net-mgmt/net-snmp, which uses at least TCPTV_MIN and TCPTV_REXMTMAX. M> Hi Charlie, M> M> why is net-mgmt/net-snmp interested in the default value of the sysctl variables M> net.inet.tcp.rexmit_min and net.inet.tcp.tcp_rexmit_max and not in the current M> value of these sysctl variables? This does not make sense to me... I'll try to find some time to make a push request for them. We already accumulates some hot fixes in the port, now this adds up. -- Gleb Smirnoff