From owner-svn-src-head@freebsd.org Mon Feb 4 16:56:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FFDC14D532D; Mon, 4 Feb 2019 16:56:21 +0000 (UTC) (envelope-from andrew@freebsd.org) Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16]) by mx1.freebsd.org (Postfix) with ESMTP id 3A86A8E886; Mon, 4 Feb 2019 16:56:21 +0000 (UTC) (envelope-from andrew@freebsd.org) Received: from [IPv6:2001:630:212:2a8:fd2e:3743:2e77:56f4] (unknown [IPv6:2001:630:212:2a8:fd2e:3743:2e77:56f4]) by fry.fubar.geek.nz (Postfix) with ESMTPSA id 897114E691; Mon, 4 Feb 2019 16:55:41 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: svn commit: r343713 - in head/sys: amd64/conf arm64/conf From: Andrew Turner In-Reply-To: Date: Mon, 4 Feb 2019 16:55:40 +0000 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <078B413A-80B9-4467-8E32-3D0DB7EDE32B@freebsd.org> References: <201902031246.x13CkRY5049231@repo.freebsd.org> To: Li-Wen Hsu X-Mailer: Apple Mail (2.3445.100.39) X-Rspamd-Queue-Id: 3A86A8E886 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.91 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.91)[-0.909,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 16:56:21 -0000 This should be fixed in r343746. Andrew > On 4 Feb 2019, at 05:28, Li-Wen Hsu wrote: >=20 > On Sun, Feb 3, 2019 at 8:46 PM Andrew Turner = wrote: >>=20 >> Author: andrew >> Date: Sun Feb 3 12:46:27 2019 >> New Revision: 343713 >> URL: https://svnweb.freebsd.org/changeset/base/343713 >>=20 >> Log: >> Enable COVERAGE and KCOV by default on arm64 and amd64. >>=20 >> This allows userspace to trace the kernel using the coverage = sanitizer >> found in clang. It will also allow other coverage tools to be built = as >> modules and attach into the same framework. >>=20 >> Sponsored by: DARPA, AFRL >>=20 >> Modified: >> head/sys/amd64/conf/GENERIC >> head/sys/arm64/conf/GENERIC >>=20 >> Modified: head/sys/amd64/conf/GENERIC >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/amd64/conf/GENERIC Sun Feb 3 11:41:43 2019 = (r343712) >> +++ head/sys/amd64/conf/GENERIC Sun Feb 3 12:46:27 2019 = (r343713) >> @@ -102,8 +102,8 @@ options MALLOC_DEBUG_MAXZONES=3D8 # Separate = malloc(9) >> options VERBOSE_SYSINIT=3D0 # Support = debug.verbose_sysinit, off by default >>=20 >> # Kernel Sanitizers >> -#options COVERAGE # Generic kernel coverage. = Used by KCOV >> -#options KCOV # Kernel Coverage Sanitizer >> +options COVERAGE # Generic kernel coverage. = Used by KCOV >> +options KCOV # Kernel Coverage Sanitizer >> # Warning: KUBSAN can result in a kernel too large for loader to load >> #options KUBSAN # Kernel Undefined Behavior = Sanitizer >>=20 >>=20 >> Modified: head/sys/arm64/conf/GENERIC >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/arm64/conf/GENERIC Sun Feb 3 11:41:43 2019 = (r343712) >> +++ head/sys/arm64/conf/GENERIC Sun Feb 3 12:46:27 2019 = (r343713) >> @@ -94,8 +94,8 @@ options USB_DEBUG # enable = debug msgs >> options VERBOSE_SYSINIT=3D0 # Support = debug.verbose_sysinit, off by default >>=20 >> # Kernel Sanitizers >> -#options COVERAGE # Generic kernel coverage. = Used by KCOV >> -#options KCOV # Kernel Coverage Sanitizer >> +options COVERAGE # Generic kernel coverage. = Used by KCOV >> +options KCOV # Kernel Coverage Sanitizer >> # Warning: KUBSAN can result in a kernel too large for loader to load >> #options KUBSAN # Kernel Undefined Behavior = Sanitizer >=20 > This breaks gcc build: > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/8781/console : >=20 > x86_64-unknown-freebsd12.0-gcc: error: unrecognized command line > option '-fsanitize-coverage=3Dtrace-pc,trace-cmp'; did you mean > '-fsanitize-coverage=3Dtrace-pc'? >=20 > We probably need to adjust arguments passed to gcc. >=20 > Li-Wen >=20