From owner-freebsd-ports@FreeBSD.ORG Mon May 25 15:14:12 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88FED1065672 for ; Mon, 25 May 2009 15:14:12 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108]) by mx1.freebsd.org (Postfix) with ESMTP id E1DFF8FC1B for ; Mon, 25 May 2009 15:14:11 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from [172.19.10.16] (nat-application.b1.lan.prg.vol.cz [195.122.204.152]) (authenticated bits=0) by raven.customer.vol.cz (8.14.3/8.14.3) with ESMTP id n4PFE3Zb046415; Mon, 25 May 2009 17:14:04 +0200 (CEST) (envelope-from pav@FreeBSD.org) From: Pav Lucistnik To: David Naylor In-Reply-To: <200905251011.16083.naylor.b.david@gmail.com> References: <20090522.195350.193746535.chat95@mac.com> <200905242007.06917.naylor.b.david@gmail.com> <1243194956.21797.4.camel@hood.oook.cz> <200905251011.16083.naylor.b.david@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-w1Bij2QuWb4oinS+sIaW" Date: Mon, 25 May 2009 17:14:01 +0200 Message-Id: <1243264441.37480.23.camel@pav.hide.vol.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Scanned-By: MIMEDefang 2.64 on 195.250.144.108 X-Milter: Spamilter (Reciever: raven.customer.vol.cz; Sender-ip: 195.122.204.152; Sender-helo: [172.19.10.16]; ) Cc: pgollucci@p6m7g8.com, Ion-Mihai Tetcu , freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2009 15:14:12 -0000 --=-w1Bij2QuWb4oinS+sIaW Content-Type: text/plain; charset="ISO8859-2" Content-Transfer-Encoding: quoted-printable David Naylor p=ED=B9e v po 25. 05. 2009 v 10:11 +0200: > > > > > > > This part looks OK, I wonder if there's any reason t ain't li= ke > > > > > > > this now; Pav? > > > > > > > -.if defined(MAKE_JOBS_NUMBER) > > > > > > > +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus` > > > > > > > _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER} > > > > > > > -.else > > > > > > > -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus` > > > > > > > -.endif > > > > > > > > > > > > Wouldn't that mean an evaluation of the backtick command in eve= ry > > > > > > make(1) invocation? That would be highly undesirable. > > > > > > I don't believe that is the case. > > > > > > Here is what I get with the patch applied (MAKE_JOBS_NUMBER not defin= ed): > > > /usr/ports/editors/openoffice.org-3# make -V MAKE_JOBS_NUMBER -V > > > _MAKE_JOBS `/sbin/sysctl -n kern.smp.cpus` > > > -j`/sbin/sysctl -n kern.smp.cpus` > > > > > > Wouldn't this indicate that the backtick command is not being evaluat= ed? > > > > Seems correct. But explain again, why you need this change?=20 >=20 > Not all ports use make but are concurrent capable and require different=20 > arguments to be passed which is why I needed to expose MAKE_JOBS_NUMBER=20 > (since it is just a number) and why _MAKE_JOBS was not an option. =20 Ok, how about doing a dirty hack and using ${_MAKE_JOBS:C/-j//} ? Then we wouldn't have to modify bsd.port.mk .. --=20 Pav Lucistnik > Why do we need a film of "Lord of the Rings" when we have the book? Because watching a cg enhanced Legolas fire a flaming arrow into the heart of a warg is cool? - asdf@asdf.com in rec.games.roguelike.angband --=-w1Bij2QuWb4oinS+sIaW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkoatbkACgkQntdYP8FOsoJquACgz7Nt0dH3PIll0Qi2jBZsEDnf 3xAAn00JVcKQlj//ioHZnHKBBILBjyLp =lbSh -----END PGP SIGNATURE----- --=-w1Bij2QuWb4oinS+sIaW--