From owner-freebsd-hardware@FreeBSD.ORG  Fri Jun 12 08:35:21 2009
Return-Path: <owner-freebsd-hardware@FreeBSD.ORG>
Delivered-To: freebsd-hardware@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6726E1065672
	for <freebsd-hardware@freebsd.org>;
	Fri, 12 Jun 2009 08:35:21 +0000 (UTC) (envelope-from ray@ddteam.net)
Received: from mail-fx0-f220.google.com (mail-fx0-f220.google.com
	[209.85.220.220])
	by mx1.freebsd.org (Postfix) with ESMTP id F29D58FC0A
	for <freebsd-hardware@freebsd.org>;
	Fri, 12 Jun 2009 08:35:20 +0000 (UTC) (envelope-from ray@ddteam.net)
Received: by fxm20 with SMTP id 20so1866981fxm.43
	for <freebsd-hardware@freebsd.org>;
	Fri, 12 Jun 2009 01:35:20 -0700 (PDT)
Received: by 10.204.57.67 with SMTP id b3mr3373861bkh.99.1244794175985;
	Fri, 12 Jun 2009 01:09:35 -0700 (PDT)
Received: from terran.mk.farlep.net (i183-101-19-89.vpdn.way.kv.chereda.net
	[89.19.101.183])
	by mx.google.com with ESMTPS id 19sm833911fkr.55.2009.06.12.01.09.35
	(version=SSLv3 cipher=RC4-MD5); Fri, 12 Jun 2009 01:09:35 -0700 (PDT)
Sender: Alex RAY <ray@ddteam.net>
Date: Fri, 12 Jun 2009 11:09:32 +0300
From: Alexandr Rybalko <ray@dlink.ua>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-Id: <20090612110932.22f2dfa6.ray@dlink.ua>
Organization: D-Link
X-Mailer: Sylpheed 2.6.0 (GTK+ 2.14.7; i386-portbld-freebsd7.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: freebsd-mips@freebsd.org, freebsd-hardware@freebsd.org
Subject: CFI
X-BeenThere: freebsd-hardware@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: General discussion of FreeBSD hardware <freebsd-hardware.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hardware>, 
	<mailto:freebsd-hardware-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hardware>
List-Post: <mailto:freebsd-hardware@freebsd.org>
List-Help: <mailto:freebsd-hardware-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hardware>, 
	<mailto:freebsd-hardware-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2009 08:35:21 -0000

Good day!

Writing to you Warner because you made cfi driver.
I found what Spansion S29AL032D90TFII03 and S29GL064A90TFI03 detect in byte mode on addresses shifted by 1,
and in chip manual I found what, 
in byte mode we read on shifted address (like 0x20 for 'Q'),
in word mode we read on non shifted address (like 0x10 for 'Q')

So if we wont to use same driver for any CFI chips, we need to test on shifted addresses.

Temporary I change
val = bus_space_read_1(sc->sc_tag, sc->sc_handle, ofs);
to
val = bus_space_read_1(sc->sc_tag, sc->sc_handle, ofs<<1);

And chip detect correctly.

Thunks.

-- 
Alexandr Rybalko <ray@dlink.ua>