From owner-svn-src-head@freebsd.org Mon Jun 3 14:13:26 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B10215B2329 for ; Mon, 3 Jun 2019 14:13:26 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-it1-f173.google.com (mail-it1-f173.google.com [209.85.166.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4D798243F for ; Mon, 3 Jun 2019 14:13:25 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-it1-f173.google.com with SMTP id i21so7934044ita.5 for ; Mon, 03 Jun 2019 07:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e5k99/l5+bjQDBJMv9ieqMVq0QWuCWBWCyFThhq9HUI=; b=Mcl5Fh+cNq5ONn3XtGTEEB0D0vtCS7ol34oHwZ+KA5NaeLgCFmHgmlRSMQTGye4oRp Gmdg/S0fbv0DaNG5b4Psh0LCHWKMsLaF9ofOxc3bSXl31QI6FVkEtOerg+1bCxBB75HF rtb1cIWKrVkW03Z4HYRyRF1HaPqmTV1vbu6QWOtow9CSQzySz6rWnDu9tUDAx90s9qIS WieHhf/uhGEGUK+kDnH5ZWTgvnyOtxXZgsuhkNGCK7EuftTY7UB5Ge8CBIOxWxSaEwiV qZgWazj5iQPmqG1G93FAj33sjSRKmp5LDIww8PO8vdcULzzvV0kuPtMBlTMywKQFsW2o b7rg== X-Gm-Message-State: APjAAAVc5eOWhOL0NUBYGIWUKmMM93UbBmKxI3nY1BlxUdpVVKFYRiVj 5QxWQytcrdyH8DMhMzml2Rb5vgnPH2ym62pPCrozPw4PJIc= X-Google-Smtp-Source: APXvYqzzNb6xj5lL4wwFEhPJVSonRnF3CpdMworIf5eiql5UGSGr5wxhXNUeqeHZJXwOG6nNE4znDLa/2MdQ3Dav1d4= X-Received: by 2002:a02:950a:: with SMTP id y10mr18088106jah.26.1559571198821; Mon, 03 Jun 2019 07:13:18 -0700 (PDT) MIME-Version: 1.0 References: <201906031147.x53Blc0b013004@slippy.cwsent.com> <201906031354.x53DsV3X043188@gndrsh.dnsmgr.net> In-Reply-To: From: Maxim Sobolev Date: Mon, 3 Jun 2019 07:13:07 -0700 Message-ID: Subject: Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb To: Warner Losh Cc: "Rodney W. Grimes" , Cy Schubert , Andrew Turner , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: A4D798243F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 14:13:26 -0000 Looking into it, sorry for breakage. Somehow it worked here. :( I'll backout if I cannot figure it out in a 30 minutes or so. Sorry about that. -Max On Mon, Jun 3, 2019 at 7:10 AM Warner Losh wrote: > > > On Mon, Jun 3, 2019 at 7:54 AM Rodney W. Grimes > wrote: > >> > In message <7BD6B7AD-5950-4015-B95D-9FFB609F51E9@fubar.geek.nz>, >> Andrew Turner >> > writes: >> > > >> > > >> > > > On 3 Jun 2019, at 00:38, Maxim Sobolev wrote: >> > > > >> > > > Author: sobomax >> > > > Date: Sun Jun 2 23:38:19 2019 >> > > > New Revision: 348521 >> > > > URL: https://svnweb.freebsd.org/changeset/base/348521 >> > > > >> > > > Log: >> > > > Fix several places where tool name has been hardcoded: >> > > > >> > > > install -> ${INSTALL} >> > > > mtree -> ${MTREE_CMD} >> > > > services_mkdb -> ${SERVICES_MKDB_CMD} >> > > > cap_mkdb -> ${CAP_MKDB_CMD} >> > > > pwd_mkdb -> ${PWD_MKDB_CMD} >> > > > kldxref -> ${KLDXREF_CMD} >> > > > >> > > > If you do custom FreeBSD builds you may want to override those >> > > > in some cases. >> > > > >> > > > Sponsored by: Sippy Software, Inc. >> > > >> > > This breaks installworld in a local Jenkins instance. I???m building >> with -DD >> > > B_FROM_SRC and -DNO_ROOT. It looks like INSTALL is unset. >> > > >> > > Andrew >> > > >> > > -------------------------------------------------------------- >> > > >>> Making hierarchy >> > > -------------------------------------------------------------- >> > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head; make -f >> Makefile.inc1 >> > > LOCAL_MTREE= hierarchy >> > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head/etc; >> PATH=/jenkins/work >> ... >> > >> > It also breaks poudirere builds at make distrib-dirs, amd64 and i386, >> i386 >> > distrib-dirs on amd64 sample below. The src/etc/Makefile distrib-dirs >> target >> > is the failing one. >> >> Something is pretty broke here then, as INSTALL has been defined for >> ever in sys.mk: >> sys.mk:INSTALL ?= install >> > > The problem is that MTREE isn't defined, which makes MTREE_CMD start with > -N. > > Warner >