From nobody Thu Mar 17 12:28:14 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 20FF91A25B85; Thu, 17 Mar 2022 12:28:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KK5yk46rSz4r3Z; Thu, 17 Mar 2022 12:28:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647520095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=obUKbnUrwBmcKK928KPKbfCemPuCr7lZvK861/5Bexw=; b=q7Yd9tYlmeQVGjaDGWsP48rn+vjYlkPPgijAQG7WMNRMvL1jlTQkw+j5383EEwNQa0MW3y i1tPz4h21IXEJ8K8RnfbI5FrGth9FbeOUH+mnhd6q7tjXFLbHFpB6H88AuyQljjM4xmlIQ VXLknLf2XzTYbaxDdfljoW9G/hULYJTu8GEFz1H0q9huq5+8s//6W9/MyGZyhG6tMscK3l 8fEOx/F0726aueD/MxP17bMCx8n/QtPOAgMj8LdlmrY/98ZWsv5RhnQE/B0C1qruvZ0ALJ CnpsXyXclNOAAuJih2JTaLccJ7zf+18waxWTFQyiggjJaewPwWQ5lLmZIwAfaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 696FD2781; Thu, 17 Mar 2022 12:28:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22HCSEUP083933; Thu, 17 Mar 2022 12:28:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22HCSEJS083932; Thu, 17 Mar 2022 12:28:14 GMT (envelope-from git) Date: Thu, 17 Mar 2022 12:28:14 GMT Message-Id: <202203171228.22HCSEJS083932@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: 09fcb3900f1b - releng/13.1 - lindebugfs: Zero the linux_file structure before use. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.1 X-Git-Reftype: branch X-Git-Commit: 09fcb3900f1b86efc250b62ee913b57a064d7d8f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647520095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=obUKbnUrwBmcKK928KPKbfCemPuCr7lZvK861/5Bexw=; b=fi5gVKKfxGn211HLji/1luuOPyv/VxLyZtFaPZXunK67T4iFn7aW9m2hr/UoKXCygy8KHd NhJcW/hIEFoQFUJGk0r7lS1QTMHO9TNMmkbtRhRmrRn1NSNga/ie8ikqziVzyX0arIqSce 0ag378Ob38SrPRyDkSLBZiYnd5WzMRvaGjPnWfZyBqM0GlIV7NsYG0oOAJNNLfj0q86Zu4 2WnlC7LCMOn7vZFr1y1feW7tH2FrlzLawf+HYOpjlH5CwPWx73c9XKJXB6r6ue+Z+HBwh+ X6BNz08graM+8jdFJOI2zASWSEo5+o5UAn1ugPwDRH66+A9fHws/FhT2Udn75A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647520095; a=rsa-sha256; cv=none; b=hiiWiORzF7+ToQl1Uu4hIFCluFZD6+5KUW6jn74wcxZjIOQAYdNoX/SItUOcx/FcAJXZqy 5cDnl2DCnDjMzW9h5LeS3vl79dpYi9fLuV7IGZRCfqvMnEv47G/5MTrmnzvQa+wcdpq+6Q crgqHeom48L/Bf8EOVnSTqCXnIdaw3EAsqHavF6u1TOJZQ7TGwi1y0qtrGZ4R2W3ty+/5M kvKNWIYM85dc/a3/ekxqdyDhf/AQog/Bu42P3kn/DKmdgiM2KWc2i+e+DmrBZr6GDv4WK5 p8p3BW/i5adjtNrJ6UQRi1WV94HDmZTVtyNeyS91wjI06h4hju33NDHieZGhFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch releng/13.1 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=09fcb3900f1b86efc250b62ee913b57a064d7d8f commit 09fcb3900f1b86efc250b62ee913b57a064d7d8f Author: Hans Petter Selasky AuthorDate: 2022-03-11 16:29:54 +0000 Commit: Hans Petter Selasky CommitDate: 2022-03-17 12:26:19 +0000 lindebugfs: Zero the linux_file structure before use. This avoids clients using garbage values on the stack and makes debugging easier. Sponsored by: NVIDIA Networking Approved by: re (gjb) (cherry picked from commit 88a29d89ebab1ed60607c3dab73143c3b59a0f83) (cherry picked from commit b5cc52c21d7d34eae93c996cee09e7d2896afa6e) --- sys/compat/lindebugfs/lindebugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/lindebugfs/lindebugfs.c b/sys/compat/lindebugfs/lindebugfs.c index 8eaa41412fd2..9507cded9ebd 100644 --- a/sys/compat/lindebugfs/lindebugfs.c +++ b/sys/compat/lindebugfs/lindebugfs.c @@ -117,7 +117,7 @@ static int debugfs_fill(PFS_FILL_ARGS) { struct dentry_meta *d; - struct linux_file lf; + struct linux_file lf = {}; struct seq_file *sf; struct vnode vn; void *buf; @@ -139,7 +139,6 @@ debugfs_fill(PFS_FILL_ARGS) len = sbuf_len(sb); } off = 0; - lf.private_data = NULL; rc = d->dm_fops->open(&vn, &lf); if (rc < 0) { #ifdef INVARIANTS