Date: Sat, 23 Jul 2016 11:01:57 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code : [Attachment 172884] Proposed patch (since 412348 revision) Message-ID: <bug-211201-6497-xwKQDZeQDl@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211201-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-211201-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
lightside <lightside@gmx.com> has asked gnome@FreeBSD.org for maintainer-approval: Bug 211201: print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201 Attachment 172884: Proposed patch (since 412348 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172884&action=3Dedit --- Comment #10 from lightside <lightside@gmx.com> --- Created attachment 172884 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172884&action= =3Dedit Proposed patch (since 412348 revision) Hello Piotr Kubaj and Jan Beich. I think, the replacement of "LCD_FILTERING with V40 code" is wrong proposal, because they are different options and defines: FT_CONFIG_OPTION_SUBPIXEL_RENDERING: https://www.freetype.org/freetype2/docs/reference/ft2-lcd_filtering.html https://www.freetype.org/freetype2/docs/reference/ft2-lcd_filtering.html#FT= _Lib rary_SetLcdFilter http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/c onfig/ftoption.h?id=3DVER-2-6-5#n78 TT_CONFIG_OPTION_SUBPIXEL_HINTING: https://www.freetype.org/freetype2/docs/reference/ft2-tt_driver.html#interp= rete r-version http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/include/freety= pe/c onfig/ftoption.h?id=3DVER-2-6-5#n586 The V40 option should not be enabled by default for v2.3.5 (as it was for v2.3.4), because of the following changes in v2.3.5: https://www.freetype.org -8<-- FreeType 2.6.5 2016-07-12 This release is almost identical to the previous version, with two differen= ces. - It compiles again on Mac OS X, and - it reverts the activation of subpixel hinting by default; it will be enab= led by default in the forthcoming 2.7.x series. Main reason for reverting this feature is the principle of least surprise: a sudden change in appearance of all fonts (even if the rendering improves for almost all recent fonts) shou= ld not be expected in a new micro version of a series. -->8- In docs/CHANGES file: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/CHANGES?i= d=3DVE R-2-6-5#n2 -8<-- CHANGES BETWEEN 2.6.4 and 2.6.5 I. IMPORTANT BUG FIXES - Compilation works again on Mac OS X (bug introduced in version 2.6.4). I. IMPORTANT CHANGES - The new subpixel hinting mode is now disabled by default; it will be enabled by default in the forthcoming 2.7.x series. Main reason for reverting this feature is the principle of least surprise: a sudden change in appearance of all fonts (even if the rendering improves for almost all recent fonts) should not be expected in a new micro version of a series. -->8- The FreeType 2 font engine is dual licensed: https://www.freetype.org/license.html http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/LICENSE.T= XT?i d=3DVER-2-6-5 http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/FTL.TXT?i= d=3DVE R-2-6-5 http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/docs/GPLv2.TXT= ?id=3D VER-2-6-5 Therefore, I would like to propose slightly different patch, with following changes (including changes from Piotr Kubaj): - Add license information [1, 2] - Add new sub-pixel hinting options [1, 2] - Regenerate patch [2] - Adapt pkg-plist [1] [1] - changes made by Piotr Kubaj. [2] - changes made by me. Also, I manually regenerated TIMESTAMP value for distinfo file with using following command: % make clean extract && find work/* -type f -print0 | xargs -0 stat -f '%m'= | sort -u | tail -1 based on "last modification time of the source" files, according to "SOURCE_DATE_EPOCH specification": https://reproducible-builds.org/specs/source-date-epoch/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211201-6497-xwKQDZeQDl>