From owner-freebsd-net@FreeBSD.ORG Wed Mar 17 09:26:41 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF0A916A4CF for ; Wed, 17 Mar 2004 09:26:40 -0800 (PST) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3732543D3F for ; Wed, 17 Mar 2004 09:26:40 -0800 (PST) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 3DD871FFDC1; Wed, 17 Mar 2004 18:26:38 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 5B6B41FFDBC; Wed, 17 Mar 2004 18:26:36 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id CF21F154FC; Wed, 17 Mar 2004 17:26:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id C44B915384; Wed, 17 Mar 2004 17:26:28 +0000 (UTC) Date: Wed, 17 Mar 2004 17:26:28 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Julian Elischer In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: David Malone cc: freebsd-net@freebsd.org Subject: Re: PPPoE buglet... X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2004 17:26:41 -0000 On Wed, 17 Mar 2004, Julian Elischer wrote: > On Wed, 17 Mar 2004, David Malone wrote: > > > I spent a while trying to get PPPoE going through a Netopia smart > > modem last night. To cut a long story short, the values for > > PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least > > when compared with tcpdump, linux and the RFC). We have: > > > > #if BYTE_ORDER == BIG_ENDIAN > > #define PTT_RELAY_SID (0x0106) > > #else > > #define PTT_RELAY_SID (0x0601) > > #endif > > > > but we should have: > > > > #if BYTE_ORDER == BIG_ENDIAN > > #define PTT_RELAY_SID (0x0110) > > #else > > #define PTT_RELAY_SID (0x1001) > > #endif > > > > Anyone object to my fixing it? The only thing I can think of that > > it might break would be people using ng_pppoe as a PPPoE relay with > > only ng_pppoe PPPoE clients. > > The RFC is al that matters (except for > the compatibility code for idiot suppliers that use the wrong > ethertype.) > > Is there a 110 or 1001 nearby that I may have read in error in the spec? 0x0110 Relay-Session-Id I think you might just have incremented the number as the paragraphs before go 0x0101, 0x0102, 0x0103, 0x0104, 0x0105, 0x010610 *uups* ;-) PS: and please no TOFU. -- Greetings Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT 56 69 73 69 74 http://www.zabbadoz.net/