From owner-freebsd-stable@FreeBSD.ORG  Wed Jun 20 20:39:50 2007
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: freebsd-stable@freebsd.org
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AD06616A46B
	for <freebsd-stable@freebsd.org>; Wed, 20 Jun 2007 20:39:50 +0000 (UTC)
	(envelope-from hg@queue.to)
Received: from pickle.queue.to (pickle.queue.to [71.180.69.18])
	by mx1.freebsd.org (Postfix) with ESMTP id 3739713C45A
	for <freebsd-stable@freebsd.org>; Wed, 20 Jun 2007 20:39:50 +0000 (UTC)
	(envelope-from hg@queue.to)
Received: (qmail 83865 invoked from network); 20 Jun 2007 16:13:08 -0400
Received: from cally.queue.to (172.16.0.6)
	by pickle.queue.to with ESMTP; 20 Jun 2007 16:13:08 -0400
Message-ID: <46798A54.20801@queue.to>
Date: Wed, 20 Jun 2007 16:13:08 -0400
From: Howard Goldstein <hg@queue.to>
User-Agent: Thunderbird 2.0.0.4 (X11/20070615)
MIME-Version: 1.0
To: freebsd-stable@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: how much beer do I need to get this patch applied?
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2007 20:39:50 -0000

This is a no brainer. The patch seems to retain the current behavior. 
The desired behavior is on a knob. It doesn't run enough to worry about 
the extra cycles to run the conditional.  A superficial googling will 
show that emitting messages when there's no exception is a human factors 
boo-boo, therefore this is a bug fix or at least not a request for 
spurious feature.   Even though the present incarnation appears to be 
(IMO) borked, least surprise doctrine and inertia suggests committing 
the patch and moving on.