From owner-svn-src-all@freebsd.org  Wed Aug 15 17:17:10 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2C0E106925E;
 Wed, 15 Aug 2018 17:17:09 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 22BEA9738D;
 Wed, 15 Aug 2018 17:17:09 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from [192.168.1.5] (c-71-198-162-232.hsd1.ca.comcast.net
 [71.198.162.232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: rpokala)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 6972D1606D;
 Wed, 15 Aug 2018 17:17:08 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
User-Agent: Microsoft-MacOutlook/10.10.0.180812
Date: Wed, 15 Aug 2018 10:17:05 -0700
Subject: Re: svn commit: r337857 - in head: bin/csh bin/sh etc
From: Ravi Pokala <rpokala@freebsd.org>
To: Brad Davis <brd@FreeBSD.org>, <src-committers@freebsd.org>,
 <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Message-ID: <3E8B8322-9A8A-4EC0-95C6-7180659E9723@panasas.com>
Thread-Topic: svn commit: r337857 - in head: bin/csh bin/sh etc
References: <201808151622.w7FGMCN7024455@repo.freebsd.org>
In-Reply-To: <201808151622.w7FGMCN7024455@repo.freebsd.org>
Mime-version: 1.0
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2018 17:17:10 -0000

Brad,

-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Brad Davis <brd@FreeBSD.org>
Date: 2018-08-15, Wednesday at 09:22
To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: svn commit: r337857 - in head: bin/csh bin/sh etc

> Author: brd
> Date: Wed Aug 15 16:22:12 2018
> New Revision: 337857
> URL: https://svnweb.freebsd.org/changeset/base/337857
> 
> Log:
>   Fix build after r337849
>   
>   This moves the symlink creation to after where the files are installed.
>   
>   This also inverts the shell change so that it only happens if MK_TCSH is on.
...
> Modified: head/etc/master.passwd
> ==============================================================================
> --- head/etc/master.passwd	Wed Aug 15 16:16:59 2018	(r337856)
> +++ head/etc/master.passwd	Wed Aug 15 16:22:12 2018	(r337857)
> @@ -1,6 +1,6 @@
>  # $FreeBSD$
>  #
> -root::0:0::0:0:Charlie &:/root:/bin/csh
> +root::0:0::0:0:Charlie &:/root:/bin/sh
>  toor:*:0:0::0:0:Bourne-again Superuser:/root:
>  daemon:*:1:1::0:0:Owner of many system processes:/root:/usr/sbin/nologin
>  operator:*:2:5::0:0:System &:/:/usr/sbin/nologin

Woah! Changing the root shell wasn't mentioned in the change description, has nothing to do with fixing r337849, and is a *HUGE* POLA violation. At the very least, a change of this magnitude needs public discussion, and even if the community agreed, it would also require an UPDATING message and relnote.

Please revert this change to master.passwd immediately.

-Ravi (rpokala@)