From owner-dev-commits-src-all@freebsd.org Fri May 7 18:03:36 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8156637854; Fri, 7 May 2021 18:03:36 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcJGc3Y36z4vfr; Fri, 7 May 2021 18:03:36 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:7c86:1978:3046:7dff]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id E4ADF71E3FEFE; Fri, 7 May 2021 20:03:32 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. From: Michael Tuexen In-Reply-To: Date: Fri, 7 May 2021 20:03:32 +0200 Cc: Li-Wen Hsu , Randall Stewart , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <78FF7B31-B84D-4D97-9E57-D000A6B09D7D@macmic.franken.de> References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> To: Gordon Bergling X-Mailer: Apple Mail (2.3654.80.0.2.43) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4FcJGc3Y36z4vfr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 18:03:36 -0000 > On 7. May 2021, at 19:47, Gordon Bergling wrote: >=20 > On Fri, May 07, 2021 at 05:39:37PM +0800, Li-Wen Hsu wrote: >> On Thu, May 6, 2021 at 11:26 PM Randall Stewart = wrote: >>>=20 >>> The branch main has been updated by rrs: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D5d8fd932e418f03e98b3469c4088a36f= 0ef34ffe >>>=20 >>> commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe >>> Author: Randall Stewart >>> AuthorDate: 2021-05-06 15:22:26 +0000 >>> Commit: Randall Stewart >>> CommitDate: 2021-05-06 15:22:26 +0000 >>>=20 >>> This brings into sync FreeBSD with the netflix versions of rack = and bbr. >>> This fixes several breakages (panics) since the tcp_lro code was >>> committed that have been reported. Quite a few new features are >>> now in rack (prefecting of DGP -- Dynamic Goodput Pacing among = the >>> largest). There is also support for ack-war prevention. Documents >>> comming soon on rack.. >>>=20 >>> Sponsored by: Netflix >>> Reviewed by: rscheff, mtuexen >>> Differential Revision: https://reviews.freebsd.org/D30036 >>=20 >> This seems braking LINT kernel build of powerpc: >>=20 >> https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console >>=20 >> Searching "error:" leads to: >>=20 >> 00:08:15.153 = /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:214= 3:16: >> error: implicit declaration of function 'tcp_hw_highest_rate' is >> invalid in C99 [-Werror,-Wimplicit-function-declaration] >> 00:08:15.153 high_rate =3D >> tcp_hw_highest_rate(rack->r_ctl.crte); >> 00:08:15.153 ^ >>=20 >> and >>=20 >> 00:08:15.163 = /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:216= 5:16: >> error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is >> invalid in C99 [-Werror,-Wimplicit-function-declaration] >> 00:08:15.163 high_rate =3D >> tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, >> rack->rc_inp); >> 00:08:15.163 ^ >>=20 >> I suspect this is because RATELIMIT is not defined in default powerpc >> build? Is it safe to enable it? >>=20 >> Best, >> Li-Wen >=20 > That should not be something RATELIMT related. I regular test = 14-CURRENT on a > RPi4B and the build today fails with >=20 > -------------------------------------------------------------- >>>> stage 3.1: building everything > -------------------------------------------------------------- > = /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks= /rack.c:2143:16: error: implicit declaration of function = 'tcp_hw_highest_rate' is invalid in C99 = [-Werror,-Wimplicit-function-declaration] > high_rate =3D = tcp_hw_highest_rate(rack->r_ctl.crte); > ^ > = /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks= /rack.c:2165:16: error: implicit declaration of function = 'tcp_hw_highest_rate_ifp' is invalid in C99 = [-Werror,-Wimplicit-function-declaration] > high_rate =3D = tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, = rack->rc_inp); > ^ > = /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks= /rack.c:14166:15: error: implicit declaration of function = 'tcp_hw_highest_rate' is invalid in C99 = [-Werror,-Wimplicit-function-declaration] > high_rate =3D tcp_hw_highest_rate(rack->r_ctl.crte); > ^ > = /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks= /rack.c:14193:15: error: implicit declaration of function = 'tcp_hw_highest_rate_ifp' is invalid in C99 = [-Werror,-Wimplicit-function-declaration] > high_rate =3D = tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, = rack->rc_inp); > ^ > 4 errors generated. > --- rack.o --- > *** [rack.o] Error code 1 >=20 >=20 > RATELIMIT is included in my KERNCONF since I use tcp_bbr(4) for a > while on the RPi4B now. Can you post the kernel config you are using? I'm building the kernel on = an arm64 platform by using tuexen@parallels:~/freebsd-src/sys/arm64/conf % cat SCTP=20 include GENERIC ident SCTP=09 makeoptions WITH_EXTRA_TCP_STACKS=3D1 options SCTP options SCTP_DEBUG options TCPHPTS options TCP_BLACKBOX options RATELIMIT options DEBUG_REDZONE options IPFIREWALL options IPFIREWALL_VERBOSE options IPFIREWALL_VERBOSE_LIMIT=3D5 options IPFIREWALL_DEFAULT_TO_ACCEPT It looks like RATELIMIT is not defined, when tcp_ratelimit.h is = included... Best regards Michael > --Gordon