Date: Thu, 24 Apr 2014 01:24:50 GMT From: Horia Racoviceanu <horia@racoviceanu.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/188934: [PATCH] security/p5-Net-SSLeay: strip library, add EXAMPLES .if block Message-ID: <201404240124.s3O1OobY037970@cgiserv.freebsd.org> Resent-Message-ID: <201404240130.s3O1U04e088622@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 188934
>Category: ports
>Synopsis: [PATCH] security/p5-Net-SSLeay: strip library, add EXAMPLES .if block
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Apr 24 01:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Horia Racoviceanu
>Release: FreeBSD 10.0-RELEASE
>Organization:
>Environment:
FreeBSD heta 10.0-RELEASE-p1 FreeBSD 10.0-RELEASE-p1 #0: Tue Apr 8 06:45:06 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
====> Running Q/A tests (stage-qa)
Warning: lib/perl5/site_perl/5.16/mach/auto/Net/SSLeay/SSLeay.so is not stripped consider using ${STRIP_CMD}
..
=======================<phase: deinstall >============================
====>> Checking for orphaned files and directories in stage directory (missing from plist)
====>> Files or directories orphaned:
%%EXAMPLESDIR%%
%%EXAMPLESDIR%%/bio.pl
%%EXAMPLESDIR%%/bulk.pl
%%EXAMPLESDIR%%/callback.pl
%%EXAMPLESDIR%%/cb-testi.pl
%%EXAMPLESDIR%%/cli-cert.pl
%%EXAMPLESDIR%%/ephemeral.pl
%%EXAMPLESDIR%%/get_authenticated_page.pl
%%EXAMPLESDIR%%/get_page.pl
%%EXAMPLESDIR%%/get_page_cert.pl
%%EXAMPLESDIR%%/https-proxy-snif.pl
%%EXAMPLESDIR%%/makecert.pl
%%EXAMPLESDIR%%/minicli.pl
%%EXAMPLESDIR%%/passwd-cb.pl
%%EXAMPLESDIR%%/req.conf
%%EXAMPLESDIR%%/ssl-inetd-serv.pl
%%EXAMPLESDIR%%/ssl_diff.pl
%%EXAMPLESDIR%%/sslcat.pl
%%EXAMPLESDIR%%/sslecho.pl
%%EXAMPLESDIR%%/stdio_bulk.pl
%%EXAMPLESDIR%%/tcpcat.pl
%%EXAMPLESDIR%%/tcpecho.pl
%%EXAMPLESDIR%%/x509_cert_details.pl
>How-To-Repeat:
Disable EXAMPLES and rebuild
>Fix:
- Bump PORTREVISION for post-install changes
- Strip library
- Add EXAMPLES .if block
- Break lines at around 80 characters
Build log:
https://redports.org/buildarchive/20140424010607-64657/
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 351748)
+++ Makefile (working copy)
@@ -3,6 +3,7 @@
PORTNAME= Net-SSLeay
PORTVERSION= 1.58
+PORTREVISION= 1
CATEGORIES= security perl5
MASTER_SITES= CPAN
PKGNAMEPREFIX= p5-
@@ -25,9 +26,16 @@
SHEBANG_FILES= examples/*.pl
+.include <bsd.port.options.mk>
+
post-install:
+ ${STRIP_CMD} ${STAGEDIR}${SITE_PERL}/${PERL_ARCH}/auto/Net/SSLeay/SSLeay.so
+
+.if ${PORT_OPTIONS:MEXAMPLES}
@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}/
${INSTALL_SCRIPT} ${WRKSRC}/examples/*.pl ${STAGEDIR}${EXAMPLESDIR}/
- ${INSTALL_DATA} ${WRKSRC}/examples/req.conf ${STAGEDIR}${EXAMPLESDIR}/req.conf
+ ${INSTALL_DATA} ${WRKSRC}/examples/req.conf \
+ ${STAGEDIR}${EXAMPLESDIR}/req.conf
+.endif
.include <bsd.port.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404240124.s3O1OobY037970>