From owner-freebsd-fs@FreeBSD.ORG Sat Mar 26 16:51:22 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96D2A106564A for ; Sat, 26 Mar 2011 16:51:22 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm19-vm0.bullet.mail.sp2.yahoo.com (nm19-vm0.bullet.mail.sp2.yahoo.com [98.139.91.216]) by mx1.freebsd.org (Postfix) with SMTP id 71B3C8FC0C for ; Sat, 26 Mar 2011 16:51:22 +0000 (UTC) Received: from [98.139.91.70] by nm19.bullet.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 16:51:21 -0000 Received: from [98.139.91.18] by tm10.bullet.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 16:51:21 -0000 Received: from [127.0.0.1] by omp1018.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 16:49:54 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 184047.65484.bm@omp1018.mail.sp2.yahoo.com Received: (qmail 40084 invoked by uid 60001); 26 Mar 2011 16:49:53 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1301158193; bh=SDwqEejjFr7RVFjJfKv+KKcpL23MKA2c8ygZs948L2A=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=sc21HdbIvO/E+t+uIoBDm/0t84iEMX0+xJcRhe+32SNL2tOl+2sOxCnExv5F+0/C3cq0V1InlQzXZXiXyfqaMI2MJNv2Jzr0Os0MxR07xHMAxPMugLPLVkaRlKVS1+bK2/dxgJcE8RJBUAJ+Cg1UKaA6YXKZWFg4X1lpAThKlms= Message-ID: <655808.35503.qm@web113514.mail.gq1.yahoo.com> X-YMail-OSG: 3Z1LxbQVM1lM26Kr4AzGew4uOyKnsU456YS04hy2PK6cnkJ HL0O.GXxYvF3LMQsv83mDBWeOOZ827pCH2bcWArPUNoTlPifAtFgTyr5r404 GrZHyTi6qwrDfrSyiPvzNs8qpCpgSfRkRFYGzLy1BXnYfGo1M1aFopzYADOV cYUBxGFD9Pg_so9XnBQRj79nXuXiYdadauF.eabCVyl.9_fmJ0znS8R7DuQR mMvnh3DqjF6l408SF9RxiZKFnjmVwKRw2MQb8S0DfPmr9jxoXzgOQ.9rrVzS nRI8Ggw.Gh1QA4ozmnLfN0I60fta.6TmLHCRv9YVFETrI4c.1h14OJSsk6HY 9GNxm7EdyAXnqK0GHeYBpgoaDzSFFECmXC9qahOoV2Iimj.fn69nt4cfvgsj nMGTcNSmCPWv5 Received: from [200.118.159.55] by web113514.mail.gq1.yahoo.com via HTTP; Sat, 26 Mar 2011 09:49:53 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Sat, 26 Mar 2011 09:49:53 -0700 (PDT) From: "Pedro F. Giffuni" To: Kostik Belousov In-Reply-To: <20110326145210.GD78089@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mikolaj Golub , freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2011 16:51:22 -0000 --- On Sat, 3/26/11, Kostik Belousov wrote: ... > > > > > Defensive programming. On NetBSD this apparently > > started causing problems for unknown reasons, > > and doing the change > > doesn't have any ill effect on FreeBSD. > What is defensive in introducing the bug ? > The change, applied to FreeBSD, will cause panic. > Oops.. I haven't experienced it (yet) but I'll surely refrain from submitting similar patches. Sorry! Pedro.