From owner-svn-src-head@freebsd.org  Sat Jun 23 02:17:11 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A298C100AE16
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sat, 23 Jun 2018 02:17:11 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D70308E320
 for <svn-src-head@freebsd.org>; Sat, 23 Jun 2018 02:17:10 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: from mail-yb0-f175.google.com (mail-yb0-f175.google.com
 [209.85.213.175])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: eadler)
 by smtp.freebsd.org (Postfix) with ESMTPSA id A370E14D06
 for <svn-src-head@freebsd.org>; Sat, 23 Jun 2018 02:17:10 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: by mail-yb0-f175.google.com with SMTP id e84-v6so3238627ybb.0
 for <svn-src-head@freebsd.org>; Fri, 22 Jun 2018 19:17:10 -0700 (PDT)
X-Gm-Message-State: APt69E19qeTyAxVk+TtPVsIDbaLLCMBLBATxGcpS8QAWEpGSW+bd3mU5
 5p/o3ufki4ijUWFgR2S/Gb/sisxQdM3CEjzkOeN6lQ==
X-Google-Smtp-Source: ADUXVKLomeByZs6X2KiWpB5nd1AbDcwxZxvsKbFyfVP3j0h5D8xrbUxxDJlVxDd5FGQsTVfonwkKzUpyF4i4KCIzG4k=
X-Received: by 2002:a25:9b09:: with SMTP id
 y9-v6mr2105427ybn.194.1529720230079; 
 Fri, 22 Jun 2018 19:17:10 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Fri, 22 Jun 2018 19:16:39
 -0700 (PDT)
In-Reply-To: <20180622110238.v7gwug4hebuclwb6@ivaldir.net>
References: <201806220921.w5M9L21k031794@repo.freebsd.org>
 <20180622110238.v7gwug4hebuclwb6@ivaldir.net>
From: Eitan Adler <eadler@freebsd.org>
Date: Fri, 22 Jun 2018 19:16:39 -0700
X-Gmail-Original-Message-ID: <CAF6rxgmvEKg-0+TsPs==pM9ju-vqFDU1_vkecfgYd_2j=n=FjA@mail.gmail.com>
Message-ID: <CAF6rxgmvEKg-0+TsPs==pM9ju-vqFDU1_vkecfgYd_2j=n=FjA@mail.gmail.com>
Subject: Re: svn commit: r335539 - head/usr.bin/top
To: Baptiste Daroussin <bapt@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jun 2018 02:17:11 -0000

On 22 June 2018 at 04:02, Baptiste Daroussin <bapt@freebsd.org> wrote:
> wouldn't it be better with a sbuf_clear here?
>
> if != null: clear else new_auto

I did that originally and undid that for reasons I can't remember.
Will try it again, if it works, its more correct.


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams