Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Jan 2015 09:48:00 -0500
From:      John Baldwin <jhb@FreeBSD.org>
To:        Jia-Shiun Li <jiashiun@gmail.com>, Neel Natu <neelnatu@gmail.com>
Cc:        Andrey Fesenko <f0andrey@gmail.com>, FreeBSD current <freebsd-current@freebsd.org>
Subject:   Re: Haswell CPU Feature
Message-ID:  <54ABF5A0.7020709@FreeBSD.org>
In-Reply-To: <CAHNYxxO0ZV5iF243PqbXEeDZiix4AFR2vzBUUd77%2BE1tXV5Uxw@mail.gmail.com>
References:  <54AB306F.2070509@ignoranthack.me> <CAFgRE9Fg=YtoOXD3P2b_w9-rF4QCrMqWxqa2SGLLN-Gx00koVQ@mail.gmail.com> <54AB394E.5040601@ignoranthack.me> <CA%2BK5SrPBn5DCVseMJYneL04y-QBmNmfxf8gXr9P6zicwC4g5uw@mail.gmail.com> <54AB49C2.9020005@ignoranthack.me> <CAFgRE9GOMHs=Wj0Yt0Q08bPd2Dk7apkhS4otVzBk3zN6m4xaLg@mail.gmail.com> <CAHNYxxO0ZV5iF243PqbXEeDZiix4AFR2vzBUUd77%2BE1tXV5Uxw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 1/6/15 12:44 AM, Jia-Shiun Li wrote:
> On Tue, Jan 6, 2015 at 1:23 PM, Neel Natu <neelnatu@gmail.com> wrote:
> 
>> Hi Sean,
>>
>> On Mon, Jan 5, 2015 at 6:34 PM, Sean Bruno <sbruno@ignoranthack.me> wrote:
>>> I'm thinking something like this:
>>>
>>> Index: sys/x86/x86/identcpu.c
>>> ===================================================================
>>> - --- sys/x86/x86/identcpu.c    (revision 276729)
>>> +++ sys/x86/x86/identcpu.c      (working copy)
>>> @@ -781,7 +781,7 @@
>>>                                 "\011TM2"       /* Thermal Monitor 2 */
>>>                                 "\012SSSE3"     /* SSSE3 */
>>>                                 "\013CNXT-ID"   /* L1 context ID
>> available */
>>> - -                             "\014<b11>"
>>> +                               "\014SDBG"      /* IA32_DEBUG_INTERFACE
>> debug*/
>>>                                 "\015FMA"       /* Fused Multiply Add */
>>>                                 "\016CX16"      /* CMPXCHG16B
>> Instruction */
>>>                                 "\017xTPR"      /* Send Task Priority
>> Messages*/
>>>
>>>
>>
>> Looks good.
>>
> 
> Maybe also this for completeness?
> 
> # svnlite diff
> Index: sys/x86/include/specialreg.h
> ===================================================================
> --- sys/x86/include/specialreg.h        (revision 276737)
> +++ sys/x86/include/specialreg.h        (working copy)
> @@ -154,6 +154,7 @@
>  #define        CPUID2_TM2      0x00000100
>  #define        CPUID2_SSSE3    0x00000200
>  #define        CPUID2_CNXTID   0x00000400
> +#define        CPUID2_SDBG     0x00000800
>  #define        CPUID2_FMA      0x00001000
>  #define        CPUID2_CX16     0x00002000
>  #define        CPUID2_XTPR     0x00004000

Yes, please include both.  SDBG matches the label in the Intel SDM, so
that's the preferred name.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54ABF5A0.7020709>