From owner-freebsd-hackers  Tue Jun 15 10:29:14 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0E89114CF7; Tue, 15 Jun 1999 10:29:12 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.3/8.9.1) id KAA19516;
	Tue, 15 Jun 1999 10:29:07 -0700 (PDT)
	(envelope-from dillon)
Date: Tue, 15 Jun 1999 10:29:07 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199906151729.KAA19516@apollo.backplane.com>
To: Matthew Jacob <mjacob@feral.com>
Cc: freebsd-hackers@FreeBSD.ORG, peter@FreeBSD.ORG
Subject: Re: D'oh!
References:  <Pine.BSF.4.05.9906150959180.5752-100000@semuta.feral.com>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

:>         for (np2 = nhpp->lh_first; np2 != 0; np2 = np2->n_hash.le_next) {
:>                 if (mntp != NFSTOV(np)->v_mount || np2->n_fhsize != fhsize ||
:>                     bcmp((caddr_t)fhp, (caddr_t)np2->n_fhp, fhsize))
:>                         continue;
:>                 vrele(vp);
:>                 goto retry;
:>         }
:> 
:> 
:> Peter- you brought this over from FreeBSD... what's up?
:------------------------------------OpenBSD!
:

     The problem is that peter is not releasing the nfs_node_hash_lock
     when he goes to retry, creating a deadlock with himself.

     Peter, looks like a quick fix & commit to me, I'd say just go ahead
     and do it.

     Heh, I just realized how funny that first statement was :-)

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message