From owner-freebsd-current@FreeBSD.ORG  Sat Sep 18 15:19:27 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0414416A4CE
	for <freebsd-current@freebsd.org>;
	Sat, 18 Sep 2004 15:19:27 +0000 (GMT)
Received: from web14828.mail.yahoo.com (web14828.mail.yahoo.com
	[216.136.225.230])
	by mx1.FreeBSD.org (Postfix) with SMTP id A02BB43D46
	for <freebsd-current@freebsd.org>;
	Sat, 18 Sep 2004 15:19:24 +0000 (GMT)
	(envelope-from rosti_bsd@yahoo.com)
Message-ID: <20040918151924.98910.qmail@web14828.mail.yahoo.com>
Received: from [212.143.154.227] by web14828.mail.yahoo.com via HTTP;
	Sat, 18 Sep 2004 08:19:24 PDT
Date: Sat, 18 Sep 2004 08:19:24 -0700 (PDT)
From: Rostislav Krasny <rosti_bsd@yahoo.com>
To: freebsd-current@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: patch: selecting "All" on some of sysinstall(8) menus doesn't make
	any distribution marked
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Sep 2004 15:19:27 -0000

> uname -a
FreeBSD localhost 5.3-BETA4 FreeBSD 5.3-BETA4 #0: Thu Sep 16 19:19:27
IDT 2004     root@localhost:/usr/obj/usr/src/sys/GENERIC  i386

Hi,

When one select "All" on some of the "Distributions" menus of
sysinstall(8) no distribution is marked but actually all of them are
selected for installation. It can confuse one during a new system
installation. Following patch fixes this problem:

--- dist.c.prev Sat Sep 18 17:37:01 2004
+++ dist.c      Sat Sep 18 17:38:06 2004
@@ -291,7 +291,7 @@
     XOrgDists = DIST_XORG_ALL;
     i = distMaybeSetPorts(self);
     distVerifyFlags();
-    return i;
+    return i | DITEM_REDRAW;
 }

 static int


If you want test this patch on installed system try following scenario
before and after applying it to your source:

1. run 'sysinstall' as a root
2. go to "Custom | Distributions" or to "Custom | Distributions |
Custom" menu
3. select "All" on the menu and see what distributions are marked after
that

P.S. If this patch is correct it should be commited to 5.3 before the
release, IMHO.


	
		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - 100MB free storage!
http://promotions.yahoo.com/new_mail