From owner-svn-src-head@freebsd.org Sun Nov 11 01:07:41 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6B4F211226F0; Sun, 11 Nov 2018 01:07:41 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B544850C3; Sun, 11 Nov 2018 01:07:40 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id wAB17cji018294; Sat, 10 Nov 2018 17:07:38 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id wAB17cA2018293; Sat, 10 Nov 2018 17:07:38 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r340326 - head In-Reply-To: To: Ben Woods Date: Sat, 10 Nov 2018 17:07:38 -0800 (PST) CC: rgrimes@freebsd.org, Ben Woods , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 9B544850C3 X-Spamd-Result: default: False [1.79 / 200.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.52)[0.520,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: pdx.rh.CN85.dnsmgr.net]; NEURAL_SPAM_LONG(0.05)[0.053,0]; NEURAL_SPAM_MEDIUM(0.34)[0.344,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.02)[country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 01:07:41 -0000 [ Charset UTF-8 unsupported, converting... ] > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > If your going to bother with a differential, and invite people to > > it you should give them at least 24 hours, and preferably 72 hours > > to respond to the new review. Reviews that last < 4 hours are not > > code reviews. > > > > -- > > Rod Grimes > > rgrimes@freebsd.org > > > Hi Rod, > > Sorry. The main reason I submitted the code review is because I do not have > my src commit bit, so needed to seek approval to commit. All the more reason for it to wait until the people you *invited* to the review to have a chance to respond. I do not believe an "accept" in a review is an "approve to commit beyond your normal scope". Was cem aware that he was "approving a non src committer to commit this change to the src tree" as your review has no mention that you are seeking src bit approval to commit there. > > I felt the need to commit the UPDATING entry was time sensitive, given the > change it was notifying users of had already been committed. > > Regards, > Ben > -- -- Rod Grimes rgrimes@freebsd.org