From owner-freebsd-current@freebsd.org Thu Aug 1 20:10:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F70CA1079; Thu, 1 Aug 2019 20:10:02 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4601c95zmcz4DTh; Thu, 1 Aug 2019 20:10:01 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 4601c25BhNz3kw4; Thu, 1 Aug 2019 20:09:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id v9nI8N5qApLH; Thu, 1 Aug 2019 20:09:54 +0000 (UTC) Received: from vivi.daemonic.se (vivi.daemonic.se [IPv6:2001:470:dca9:2::4]) by mail.daemonic.se (Postfix) with ESMTPSA id 4601c15zblz3c7W; Thu, 1 Aug 2019 20:09:53 +0000 (UTC) Subject: Re: drm-legacy is broken, again To: sgk@troutmask.apl.washington.edu, Mark Johnston Cc: freebsd-x11@freebsd.org, freebsd-current@freebsd.org References: <20190801191009.GA8229@troutmask.apl.washington.edu> <20190801192227.GB19051@raichu> <20190801193024.GA29819@troutmask.apl.washington.edu> <20190801193115.GC19051@raichu> <20190801194218.GA32463@troutmask.apl.washington.edu> From: Niclas Zeising Message-ID: Date: Thu, 1 Aug 2019 22:09:53 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190801194218.GA32463@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4601c95zmcz4DTh X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-0.86 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.86)[-0.864,0]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Aug 2019 20:10:02 -0000 On 2019-08-01 21:42, Steve Kargl wrote: > On Thu, Aug 01, 2019 at 03:31:15PM -0400, Mark Johnston wrote: >> On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote: >>> On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote: >>>> On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote: >>>>> Just updated /usr/src to top of tree. >>>>> >>>>> Trying to update drm-legacy port. After >>>>> a failed 'make' in /usr/ports/drm-legacy >>>> >>>> The patch below should fix it. drm was relying on refcount.h including >>>> limits.h. >>>> >>>> diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h >>>> index 3af7ad1..7cbd8db 100644 >>>> --- a/src/dev/drm2/drmP.h >>>> +++ b/src/dev/drm2/drmP.h >>>> @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$"); >>>> >>>> #include >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>> >>> Thanks for the quick response. I had recalled someone >>> has/had been undoing some header pollution changes, >>> but the individual names escaped me. >> >> I reproduced the issue and submitted a PR: >> https://github.com/FreeBSDDesktop/drm-legacy/pull/13 > > > Thanks for that, too. I'm not in a position to > submit a PR as my mouse has gone missing under > Xorg. > Port has been updated: https://svnweb.freebsd.org/changeset/ports/507828 Regards -- Niclas Zeising