From owner-freebsd-arch  Fri Mar 23 12:30: 8 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0E12037B71A; Fri, 23 Mar 2001 12:30:04 -0800 (PST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id MAA07048;
	Fri, 23 Mar 2001 12:28:00 -0800 (PST)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.11.1/8.11.1) id f2NKRS928064;
	Fri, 23 Mar 2001 12:27:28 -0800 (PST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200103232027.f2NKRS928064@arch20m.dellroad.org>
Subject: Re: Critical Regions Round II
In-Reply-To: <XFMail.010322145353.jhb@FreeBSD.org> "from John Baldwin at Mar
 22, 2001 02:53:53 pm"
To: John Baldwin <jhb@FreeBSD.ORG>
Date: Fri, 23 Mar 2001 12:27:28 -0800 (PST)
Cc: arch@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL82 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

John Baldwin writes:
> Also, this entire API was forced out into MI code.  After the discussion on
> the mailing list I propose the following that will hopefully make everyone
> happy:
> 
> disable_intr()  - x86 / ia64 only, just clears the IF or psr.i bit, and is
>                   a MD function
> enable_intr()   - x86 / ia64 only, just sets the IF or psr.i bit, and is a
>                   MD function

Apologies in advance if I'm missing something obvious..

Shouldn't these be, e.g.,

  i386_disable_intr(), i386_enable_intr()

    and

  ia64_enable_intr(), ia64_disable_intr()

That is, it seems like "machine dependent" has a strict meaning,
it means: specific to a single (one) architecture.

Or are we expecting to have code that looks like this:

    #if defined(__i386__) || defined(__ia64__)
	    disable_intr()
    #endif

??

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message