From owner-freebsd-perl@FreeBSD.ORG Mon Jul 7 18:46:22 2014 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F06C0743; Mon, 7 Jul 2014 18:46:21 +0000 (UTC) Received: from mail.4securemail.com (mail.4securemail.com [64.34.211.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 55A7F2431; Mon, 7 Jul 2014 18:46:20 +0000 (UTC) Message-ID: <53BAE9C0.9050801@myarcher.net> Date: Mon, 7 Jul 2014 19:46:14 +0100 From: Barrie Archer User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 To: Ryan Steinmetz , Baptiste Daroussin , Mathieu Arnold Subject: Re: p5-Git-Repository References: <53BA9AD8.7030906@myarcher.net> <20140707134409.GA12289@exodus.zi0r.com> <20140707161318.GB74596@exodus.zi0r.com> <20140707161913.GB97203@ivaldir.etoilebsd.net> <20140707162734.GC74596@exodus.zi0r.com> In-Reply-To: <20140707162734.GC74596@exodus.zi0r.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: perl@freebsd.org, portmgr@freebsd.org X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2014 18:46:22 -0000 From an simple user's point of view this is exactly what is required, (a) a warning that things may go wrong, and (b) a probable cause if they do. Regards Barrie On 07/07/2014 17:27, Ryan Steinmetz wrote: On (07/07/14 18:19), Baptiste Daroussin wrote: On Mon, Jul 07, 2014 at 12:13:18PM -0400, Ryan Steinmetz wrote: On (07/07/14 17:55), Mathieu Arnold wrote: >+--On 7 juillet 2014 09:44:09 -0400 Ryan Steinmetz [1] wrote: >| We should either add workarounds for older systems or a warning >| that will be printed if a user is running a FreeBSD release that lacks >| required functionality for the ports tree to function. > >Well, the ports tree is only guaranteed to work with supported FreeBSD >releases. So, if you're not running a supported release, you're on your own. > >We can't add bits and pieces of version checks around everything that won't >work with older releases. We know what the supported releases are and we can easily add a check to the framework to verify that you are running a supported release and print a message if not. This would be identical to what was done with the PKGNG checks/warnings. The goal is to give the user a useful message ("You are using an unsupported version, please upgrade.") versus the errors that Barrie ran into ("Unknown modifier 't'" or "make: fatal errors encountered -- cannot continue"). Except that is that case it is impossible to catch it reliably, some impossible to warn about it. We don't need to catch anything. We simply need: .if (${OSVERSION} >= 902510 && ${OSVERSION} < 1000000) || ${OSVERSION} >= 1000704 ${ECHO} "You are using an unsupported release. The ports tree may not function correctly. Please update to a supported release for the best experience. See [2]http://.....freebsd.org/... for a list of supported releases. .endif Obviously the versions are not correct, but, again, the goal is to give people something to work with. Just like what we did with the PKGNG warnings. -r regards, Bapt --Certified Virus Free by 4SecureMail.com ICSA-Certified Scanner-- References 1. mailto:zi@FreeBSD.org 2. http://.....freebsd.org/