Date: Fri, 22 Aug 2014 00:09:30 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192878] comms/pr [maintainer] new source location Message-ID: <bug-192878-13-aZy1T8F7MR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192878-13@https.bugs.freebsd.org/bugzilla/> References: <bug-192878-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192878 --- Comment #11 from C Hutchinson <portmaster@bsdforge.com> --- (In reply to John Marino from comment #10) > (In reply to C Hutchinson from comment #9) > > Created attachment 146131 [details] > > UPDATES [maintainer] STAGED LICENSE SVN DIFF > > > > OK. This is as good as it gets. > > Then we have a problem. OK. I'm following... > > > All incantations of your proposed install loop(s) failed. > > Then it wasn't implemented correctly. I do this all the time. And I > convert loops to single commands all the time. It works. So do I. But I'm not finding the right incantation, I guess. > > > I'm not sure if you had a chance to examine the source itself. > > But it's a pure copy operation. No bin(aries), or lib's > > involved. > > Anyhow. I've made a couple of the other corrections regarding > > your "nit's" with this, and added a LICENSE, as well. I can > > imagine no reason for not letting this through. It passes with > > flying colors. > > > > See attached svn diff, for details. > > > > BTW ${CP} is completely valid, and provided in bsd.port.mk. > > Which I think is why no ALARM's were set off. :) > > No, ${CP} is not valid. You are supposed to use INSTALL_PROGRAM, > INSTALL_MAN, INSTALL_SCRIPT, INSTALL_DATA macros, never CP. Those macros do > more than copy, they control permissions, ownership, and stripping. OK INSTALL_PROGRAM won't work for simple script copies. It _tries_ but insists on strip(1)ing them. So that's out. INSTALL_MAN is quite nice. I've used it before, and it's simple as one could hope for. But doesn't apply here. INSTALL_SCRIPT looked like a real winner. But [for reasons yet to be discovered] it failed (while attempting to use your suggestion). I'm _sure_ it's correct for the ${PREFIX}/sbin files. But I guess I'll to work out some other way to use it. INSTALL_DATA is also the perfect choice for ${PREFIX}/etc && ${PREFIX}etc/rd.d. But again, see: INSTALL_SCRIPT. > > > > > > > I'm going to make a "proper" dev box, running on 11, now. > > So kindly mark this fixed. :) > > > I can't. > While the loops could be let go because they do the same thing more > inefficiently, the CP issue is a dealbreaker. > > Attempting to create a DOCDIR directory each time a file is installed is a > dealbreaker. Not using PORT_OPTIONS:MDOCS or equivalent is a dealbreaker. OK. While I whole heartedly agree, when talking more than one doc file. But we're not. It's one simple html file. As to PORT_OPTIONS:MDOCS. I've used it. I get it. It works great. But I'm not making it an option. It still matters? > > so I can accept this is the best it's going to get. I could fix all of that > in < 5 minutes. That's why you're @freebsd, and I'm simply @. :) P.S. ${CP} is in bsd.port.mk. Which is where I got the hint. I found it was used hundreds of times, in ports, in the ports tree. So while I absolutely comply with your wishes. We will have to agree to disagree on the use of ${CP}. :P OK. I'm grumpy about it. But I understand. So I'll get back on it. It's just that I really had my hopes up to create that new "dev box". :( Thanks for your critique, John. Even if it's not what I wanted to hear. :) --Chris > > > > > > The following, are for your "magnifying glass". :) > > those problems aren't going to show in redports -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192878-13-aZy1T8F7MR>