From owner-cvs-all Fri Apr 12 14:21:43 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id D481537B405 for ; Fri, 12 Apr 2002 14:21:36 -0700 (PDT) Received: (qmail 1426 invoked from network); 12 Apr 2002 21:21:35 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 12 Apr 2002 21:21:35 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g3CLMQv62231; Fri, 12 Apr 2002 17:22:26 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200204122117.g3CLHcF92496@freefall.freebsd.org> Date: Fri, 12 Apr 2002 17:20:48 -0400 (EDT) From: John Baldwin To: John Baldwin Subject: RE: cvs commit: src/sys/kern sys_process.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 12-Apr-2002 John Baldwin wrote: > jhb 2002/04/12 14:17:38 PDT > > Modified files: > sys/kern sys_process.c > Log: > Rework ptrace(2) to be more locking friendly. We do any needed copyin()'s > and acquire the proctree_lock if needed first. Then we lock the process > if necessary and fiddle with it as appropriate. Finally we drop locks and > do any needed copyout's. This greatly simplifies the locking. I've tested this on i386 lightly (gdb still works for a trivial program as far as breakpoints and running it.) Since gdb on alpha is busted this wasn't tested on alpha. :-( I would appreciate if people would make sure I haven't broken things. They shouldn't be broken in theory, but practice doesn't always == theory. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message