From nobody Wed Oct 1 09:38:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8y73NQsz69GP2; Wed, 01 Oct 2025 09:38:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8y71xRjz3H4H; Wed, 01 Oct 2025 09:38:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5y1mroI84lrRxg+/RGgxqrCgay8qHAHwqMfEA4NoPx4=; b=i+twswxvtvmo1VAbwMV4oxViWhTc7nrMLqYZm4ZfN4+LlMHl6bAYqrgT46eSCOI6EdG9Ag MTNyqvOQs2deND0j5B1r8nunClurD/F7fbWlytGgSuEpLbhvzEKFWlfptzF9xVMv/nH2Tq PjfmkFBiRC/rWNyN2rbN+EzIj8GL7O9IAaA0piPD6rpJzdUSKj0UZqexKF9bcVyD7+r4ht UMMVoU/kRxU2lpSbUuhOj+g4BZd3o8Pbrip5C+ALZlp6B7gwu/gUi58bcYehxfRhJhYRSt 5PrOnAaMaQb2orrPNC8Cq12ZpCnm/5GzHicv/nMeB/1lE9TBxnwOvt9RYRHDNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5y1mroI84lrRxg+/RGgxqrCgay8qHAHwqMfEA4NoPx4=; b=poAlHb3GjAiuD1ZTW+7ip15W5pW+I8LdF1SUaePoKsgux9z3JN94EoZOM9TNkLFumgVAAO LlFtmDLwUlx8dd8hDWpr6zBzi4GIUtqUqwjpGqMYs+4uhIrvCxgXzOarI+jxRoj8jKtiyl dqas7odmehgoA0pZ8tZ3rGgdFGL8MejAhKpG99KXPCJgyNPjl452jJI/KrnyrRqqCkjB9B mpdiH/XSe77Y99hSoVsngOau97gSBSMdmPsPZVKyuSAlW8X61F3Ryi3pqmxcctRtj4weXc Hx84yPfXDPHobvNlmqPNLlVQSPV9d1SFj38e5+dEBVMQG9tnsux1VcxmWGe3rg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311535; a=rsa-sha256; cv=none; b=fjblzQerzqi1t4WZGWYk+gxckiP7l4Eapx6Kw62pu6nnuEJFBj50WwRZ2EmzWVYNJbZC0D 21VthsaoJHafjsFxydNp0JVeDr5/Njx4WU9+5J+JSvp0lrjNgFLdqEUbT3YqJtbh8VE7jd MprzXPWFazvWhD6hDIMiQVwCunfvnDtGtVRCTucQOvFxBj2Tc7l9FNoa5NZs4Y9kuFDNpU cFAeDWoY1fxbKYM6u2QanzurcSD3Ur8oEqpM91fKf4o2ViCY/BZBjVyQr0cyRBAwMe/06B Au4dPs0sz6FMs2QOxZVzJmky7z4tiUJvgjr/D5csxbxYrPzlApR+ESajtpfcEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8y71192z2JH; Wed, 01 Oct 2025 09:38:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919ctRY016627; Wed, 1 Oct 2025 09:38:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919ct0L016624; Wed, 1 Oct 2025 09:38:55 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:55 GMT Message-Id: <202510010938.5919ct0L016624@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 6163ced966b4 - stable/14 - gpioc: fix race in ioctl(GPIOCONFIGEVENTS) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6163ced966b4e37a987e514aa2d2a61781c98fa5 Auto-Submitted: auto-generated The branch stable/14 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=6163ced966b4e37a987e514aa2d2a61781c98fa5 commit 6163ced966b4e37a987e514aa2d2a61781c98fa5 Author: Ahmad Khalifa AuthorDate: 2025-09-30 11:09:50 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 09:08:55 +0000 gpioc: fix race in ioctl(GPIOCONFIGEVENTS) A race can occur in gpioc_ioctl when it is called with GPIOCONFIGEVENTS closely followed by GPIOSETCONFIG. GPIOSETCONFIG can alter the priv->pins list, making it no longer empty and opening the door for access to priv->events while we are reallocating it. Fix this by holding priv->mtx while handling GPIOCONFIGEVENTS. Reported by: Qiu-ji Chen PR: 289120 Reviewed by: mmel MFC after: 1 day Differential Revision: https://reviews.freebsd.org/D52783 (cherry picked from commit d000adfe41e6f2fe8f3dbe92d8fc2d34ae882086) --- sys/dev/gpio/gpioc.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/sys/dev/gpio/gpioc.c b/sys/dev/gpio/gpioc.c index a3595c849a21..45757854b938 100644 --- a/sys/dev/gpio/gpioc.c +++ b/sys/dev/gpio/gpioc.c @@ -783,6 +783,7 @@ gpioc_ioctl(struct cdev *cdev, u_long cmd, caddr_t arg, int fflag, struct gpio_access_32 *a32; struct gpio_config_32 *c32; struct gpio_event_config *evcfg; + struct gpioc_pin_event *tmp; uint32_t caps, intrflags; bus = GPIO_GET_BUS(sc->sc_pdev); @@ -892,27 +893,35 @@ gpioc_ioctl(struct cdev *cdev, u_long cmd, caddr_t arg, int fflag, res = devfs_get_cdevpriv((void **)&priv); if (res != 0) break; - /* If any pins have been configured, changes aren't allowed. */ - if (!SLIST_EMPTY(&priv->pins)) { - res = EINVAL; - break; - } if (evcfg->gp_report_type != GPIO_EVENT_REPORT_DETAIL && evcfg->gp_report_type != GPIO_EVENT_REPORT_SUMMARY) { res = EINVAL; break; } - priv->report_option = evcfg->gp_report_type; /* Reallocate the events buffer if the user wants it bigger. */ - if (priv->report_option == GPIO_EVENT_REPORT_DETAIL && + tmp = NULL; + if (evcfg->gp_report_type == GPIO_EVENT_REPORT_DETAIL && priv->numevents < evcfg->gp_fifo_size) { - free(priv->events, M_GPIOC); - priv->numevents = evcfg->gp_fifo_size; - priv->events = malloc(priv->numevents * + tmp = malloc(priv->numevents * sizeof(struct gpioc_pin_event), M_GPIOC, M_WAITOK | M_ZERO); + } + mtx_lock(&priv->mtx); + /* If any pins have been configured, changes aren't allowed. */ + if (!SLIST_EMPTY(&priv->pins)) { + mtx_unlock(&priv->mtx); + free(tmp, M_GPIOC); + res = EINVAL; + break; + } + if (tmp != NULL) { + free(priv->events, M_GPIOC); + priv->events = tmp; + priv->numevents = evcfg->gp_fifo_size; priv->evidx_head = priv->evidx_tail = 0; } + priv->report_option = evcfg->gp_report_type; + mtx_unlock(&priv->mtx); break; case FIONBIO: /*