Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Jun 2019 17:12:59 +0000 (UTC)
From:      Piotr Kubaj <pkubaj@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r505210 - head/lang/python35
Message-ID:  <201906271712.x5RHCxXS037935@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pkubaj
Date: Thu Jun 27 17:12:58 2019
New Revision: 505210
URL: https://svnweb.freebsd.org/changeset/ports/505210

Log:
  lang/python35: Use -std=c99
  
  Python 3.5 is currently failing to build the pickle module on GCC-based
  architectures, with the following (several) errors:
  
    error: 'for' loop initial declaration used outside C99 mode
  
  This causes packaging to fail, as the pickle module filename changes on
  failure to build, so the plist ends up incorrect
  
  Python 3.6+ switched to using -std=c99 [1][2], but the changes were not
  backported to 3.5
  
  [1] https://bugs.python.org/issue28017
  [2] https://hg.python.org/cpython/rev/b5b2bb56d303
  [3] https://hg.python.org/cpython/rev/91017e2202ae
  
  PR: 238821
  Reviewed by: koobs (python)
  Approved by: koobs (python), mat (mentor)
  MFH: 2019Q2 (blanket: build fix)
  Differential Revision:  https://reviews.freebsd.org/D20778

Modified:
  head/lang/python35/Makefile

Modified: head/lang/python35/Makefile
==============================================================================
--- head/lang/python35/Makefile	Thu Jun 27 15:34:08 2019	(r505209)
+++ head/lang/python35/Makefile	Thu Jun 27 17:12:58 2019	(r505210)
@@ -16,6 +16,7 @@ COMMENT=	Interpreted object-oriented programming langu
 LICENSE=	PSFL
 
 USES=		cpe ncurses pathfix pkgconfig readline:port shebangfix ssl tar:xz
+USE_CSTD=	c99
 PATHFIX_MAKEFILEIN=	Makefile.pre.in
 USE_LDCONFIG=	yes
 GNU_CONFIGURE=	yes



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201906271712.x5RHCxXS037935>