From owner-cvs-all Mon Dec 30 1:49:23 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CA3C37B401; Mon, 30 Dec 2002 01:49:22 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D95843E4A; Mon, 30 Dec 2002 01:49:21 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gBU9n5In003508; Mon, 30 Dec 2002 10:49:12 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys _mutex.h From: phk@FreeBSD.org In-Reply-To: Your message of "Mon, 30 Dec 2002 14:58:30 +1100." <20021230142740.R44529-100000@gamplex.bde.org> Date: Mon, 30 Dec 2002 10:49:05 +0100 Message-ID: <3507.1041241745@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021230142740.R44529-100000@gamplex.bde.org>, Bruce Evans writes: >On Sun, 29 Dec 2002, Poul-Henning Kamp wrote: > >> phk 2002/12/29 03:14:41 PST >> >> Modified files: >> sys/sys _mutex.h >> Log: >> Save 16 bytes per mutex if MUTEX_PROFILING is not defined. >> >> MUTEX_PROFILING is in opt_global.h, so this does not introduce a risk of >> variant structure sizes unless foreign kernel modules are used. > >Not so. This breaks all modules, not just foreign ones, since >opt_global.h is not included in any module, and even if it were then >its setting for some modules might differ from the setting in the >kernel. Ok, we should make MUTEX_PROFILING an undocumented option then. A cost of 16 bytes per mutex is not warranted for a "only once in a blue moon" option. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message