From owner-freebsd-current@FreeBSD.ORG Mon Mar 5 22:41:02 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 895841065670 for ; Mon, 5 Mar 2012 22:41:02 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 16E3A8FC19 for ; Mon, 5 Mar 2012 22:41:01 +0000 (UTC) Received: by eekd17 with SMTP id d17so1737327eek.13 for ; Mon, 05 Mar 2012 14:41:01 -0800 (PST) Received-SPF: pass (google.com: domain of bschmidt@techwires.net designates 10.14.37.78 as permitted sender) client-ip=10.14.37.78; Authentication-Results: mr.google.com; spf=pass (google.com: domain of bschmidt@techwires.net designates 10.14.37.78 as permitted sender) smtp.mail=bschmidt@techwires.net Received: from mr.google.com ([10.14.37.78]) by 10.14.37.78 with SMTP id x54mr1700150eea.42.1330987261144 (num_hops = 1); Mon, 05 Mar 2012 14:41:01 -0800 (PST) Received: by 10.14.37.78 with SMTP id x54mr1265681eea.42.1330985648987; Mon, 05 Mar 2012 14:14:08 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-067-212-216.pools.arcor-ip.net. [88.67.212.216]) by mx.google.com with ESMTPS id y11sm5185684eem.3.2012.03.05.14.14.07 (version=SSLv3 cipher=OTHER); Mon, 05 Mar 2012 14:14:08 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: freebsd-current@freebsd.org Date: Mon, 5 Mar 2012 23:14:21 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> In-Reply-To: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203052314.22050.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQnMpRGNXqR6CBWAo8NIU6czOKPtr3Ln2xi0Y5SpmiOzXRlGOu/OxPA3Og3i33drmKxdQ2ol Cc: freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 22:41:02 -0000 On Monday 05 March 2012 18:42:12 Mitsuru IWASAKI wrote: > Hi, > > I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work > in WEP mode, which seems to be broken since 8.0-RELEASE. > > The patches against HEAD at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff > > I'm not sure that changes on ieee80211 layer are right fixes, > but all of mbufs were discarded in ieee80211_start() in WEP mode. > > ---- > void > ieee80211_start(struct ifnet *ifp) > { > [snip] > if (ni->ni_associd == 0 && > (ni->ni_flags & IEEE80211_NODE_ASSOCID)) { > IEEE80211_DISCARD_MAC(vap, IEEE80211_MSG_OUTPUT, > eh->ether_dhost, NULL, > "sta not associated (type 0x%04x)", > htons(eh->ether_type)); > vap->iv_stats.is_tx_notassoc++; > ifp->if_oerrors++; > m_freem(m); > ieee80211_free_node(ni); > continue; > } > ---- > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > is set. Any suggestions on this part are welcome. Are you sure the net80211 part is correct? It looks to me as if you are just masking the real issue. The IEEE80211_NODE_ASSOCID flag is ment to be used to verify that an associd has actually been set, not doing so will break other things I guess. iwi(4) is a bit tricky in that regard, as it sets the associd itself, check iwi_checkforqos(). I'd verify that function is actually called and if so if the parameters are correct. I fumbled around there once, might have wrong WEP.. > I'm going to commit the changes coming weekend. What's the reason behing adding if_qflush()/if_transmit()? -- Bernhard