From owner-freebsd-audit Thu Dec 21 5:58:31 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 21 05:58:29 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 6439937B400 for ; Thu, 21 Dec 2000 05:58:29 -0800 (PST) Received: from earth.causticlabs.com (oca-c1s4-12.mfi.net [209.26.94.151]) by peitho.fxp.org (Postfix) with ESMTP id 89AB11360E for ; Thu, 21 Dec 2000 08:58:27 -0500 (EST) Received: by earth.causticlabs.com (Postfix, from userid 1000) id 08B691F5B; Thu, 21 Dec 2000 08:58:24 -0500 (EST) Date: Thu, 21 Dec 2000 08:58:24 -0500 From: Chris Faulhaber To: audit@freebsd.org Subject: Re: Heads Up need to audit the NetBSD ftpd code Message-ID: <20001221085824.A19639@earth.causticlabs.com> References: <20001220181314.D12671@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001220181314.D12671@dragon.nuxi.com>; from obrien@freebsd.org on Wed, Dec 20, 2000 at 06:13:14PM -0800 Sender: jedgar@earth.causticlabs.com Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Dec 20, 2000 at 06:13:14PM -0800, David O'Brien wrote: > I intend to to import the NetBSD ftpd code in the near-term future. It > has much more functionality of our's -- on par of having the most useful > features of wu-ftpd. And many feel it is a better code base with less > bug (especially ones that can be security vulnerabilities). > > However, before I import it, Warner Losh thought it should be brought up > for review. > > So please have at > ftp://ftp.netbsd.org/pub/NetBSD/NetBSD-current/src/libexec/ftpd/ > Am I too paranoid in requesting that STAT and SYST only be available to users who are logged in? -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org Index: ftpcmd.y =================================================================== RCS file: /cvsroot/basesrc/libexec/ftpd/ftpcmd.y,v retrieving revision 1.48.2.1 diff -u -r1.48.2.1 ftpcmd.y --- ftpcmd.y 2000/07/25 08:38:38 1.48.2.1 +++ ftpcmd.y 2000/12/21 13:25:32 @@ -736,7 +736,7 @@ } } - | SYST CRLF + | SYST check_login CRLF { if (EMPTYSTR(version)) reply(215, "UNIX Type: L%d", NBBY); @@ -753,7 +753,7 @@ free($4); } - | STAT CRLF + | STAT check_login CRLF { statcmd(); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message