From owner-svn-src-head@FreeBSD.ORG Sun May 27 20:32:15 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7587B106567D; Sun, 27 May 2012 20:32:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 0F4548FC1E; Sun, 27 May 2012 20:32:13 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q4RKW2sm047243; Sun, 27 May 2012 23:32:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q4RKW2U6052487; Sun, 27 May 2012 23:32:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q4RKW28l052486; Sun, 27 May 2012 23:32:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 27 May 2012 23:32:02 +0300 From: Konstantin Belousov To: Roman Divacky Message-ID: <20120527203202.GX2358@deviant.kiev.zoral.com.ua> References: <201205270527.q4R5Rm44028055@svn.freebsd.org> <20120527203100.GA22921@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1MaLZ7+w12+PvFyj" Content-Disposition: inline In-Reply-To: <20120527203100.GA22921@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2012 20:32:15 -0000 --1MaLZ7+w12+PvFyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 27, 2012 at 10:31:00PM +0200, Roman Divacky wrote: > Fwiw, to enable the same thing in clang you want this simple patch: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Tools.cpp (revision 157545) > +++ Tools.cpp (working copy) > @@ -4794,6 +4794,7 @@ > if (Args.hasArg(options::OPT_static)) { > CmdArgs.push_back("-Bstatic"); > } else { > + CmdArgs.push_back("--hash-style=3Dboth"); > if (Args.hasArg(options::OPT_rdynamic)) > CmdArgs.push_back("-export-dynamic"); > CmdArgs.push_back("--eh-frame-hdr"); >=20 >=20 >=20 > I cant commit this upstream as this option doesn't work with ld 2.15. What > should be done here? Commit this to local FreeBSD version? Commit it upst= ream > making it not work with old ld? Leave it out completely? I cannot answer this question. This should be discussed with our in-tree clang maintainers. >=20 > On Sun, May 27, 2012 at 05:27:48AM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Sun May 27 05:27:47 2012 > > New Revision: 236137 > > URL: http://svn.freebsd.org/changeset/base/236137 > >=20 > > Log: > > Enable gnu hash generation for dynamic ELF binaries on x86. > > =20 > > Reviewed by: kan > >=20 > > Modified: > > head/contrib/gcc/config/i386/freebsd.h > > head/contrib/gcc/config/i386/freebsd64.h > >=20 > > Modified: head/contrib/gcc/config/i386/freebsd.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/contrib/gcc/config/i386/freebsd.h Sun May 27 05:24:53 2012 (r2= 36136) > > +++ head/contrib/gcc/config/i386/freebsd.h Sun May 27 05:27:47 2012 (r2= 36137) > > @@ -49,6 +49,7 @@ Boston, MA 02110-1301, USA. */ > > %{rdynamic: -export-dynamic} \ > > %{!dynamic-linker:-dynamic-linker %(fbsd_dynamic_linker) }} \ > > %{static:-Bstatic}} \ > > + %{!static:--hash-style=3Dboth} \ > > %{symbolic:-Bsymbolic}" > > =20 > > /* Reset our STARTFILE_SPEC which was properly set in config/freebsd.h > >=20 > > Modified: head/contrib/gcc/config/i386/freebsd64.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/contrib/gcc/config/i386/freebsd64.h Sun May 27 05:24:53 2012 (= r236136) > > +++ head/contrib/gcc/config/i386/freebsd64.h Sun May 27 05:27:47 2012 (= r236137) > > @@ -54,4 +54,5 @@ Boston, MA 02110-1301, USA. */ > > %{rdynamic:-export-dynamic} \ > > %{!dynamic-linker:-dynamic-linker %(fbsd_dynamic_linker) }} \ > > %{static:-Bstatic}} \ > > + %{!static:--hash-style=3Dboth} \ > > %{symbolic:-Bsymbolic}" --1MaLZ7+w12+PvFyj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/Cj0IACgkQC3+MBN1Mb4gG+gCfcvsTSRQn7kpHPizmfgb9nWHK aV8AoIhukCdWvB6UqfL0ANDZZwc3LnEX =/Ixo -----END PGP SIGNATURE----- --1MaLZ7+w12+PvFyj--