From owner-svn-ports-head@freebsd.org Wed Jan 13 04:13:11 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13543A805D9; Wed, 13 Jan 2016 04:13:11 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB0FC150E; Wed, 13 Jan 2016 04:13:10 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-oi0-x22f.google.com with SMTP id w75so55420219oie.0; Tue, 12 Jan 2016 20:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=pCLPTPepEs//c4Pz/18RQAONLaQ8LotZqpem/wWMvvs=; b=aBsZ1oDxQmyOStxgr4U0VkNpWNU+LQ7NVsM60so/AFKpZCJzQWhTN/D3GESJnW/WIC 0vaFtW9ODjZL5B+RSulLRl3QrE1jCQdzXIYEGJ2As7YdueX908ExDyCe8RhcUypm99D6 OShd3Ejp+M87boFEuld8qKHqLuSo3G7eDZAT/+qg3x1CAm5F3e9ZryL02+/1vxB/Od6F 0THvkIvcmZa/07OHte0rKwVXQBnYqeKbbliZvAGegWG31k6xtv1BwUJd9zubMefX9eYL 0JZz6ngXkaMAV5igzV55V/LI01YI3uN4pkWa+FmRgZW1b8ZKoVe50qRRWi6MJFLiIAM9 nMCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=pCLPTPepEs//c4Pz/18RQAONLaQ8LotZqpem/wWMvvs=; b=GP0bdv1YuXmqofOAdBrvuc9xQCqRZstH+f2OvKaNbmAgtvNFumRqyEWTBYUaUk1YPI ukgQjTwSk2hfSitN5xS3Yy1baU+RO7yFcEM8gGlL7KLPRQfNPPc7VKKyn2L3RFGAdZb4 eBKsdN0MH5RNatXsHufRjJZL87sw5l8HQzTL873w1uSiKPbNO4vISC8U/sCwtD/U/4hv QtrU64Q/1nGcMFy+wimSRqeFB/R4jfopCOo64CDYDg4/l2pApBNx2K6vK6IwyLGMDG69 lHTeD76clJgSqnRszcbpuarhOrlN/QFxMUcxWoGw6gxxHSftTtUs269/ED6qMJM7CrW+ tmfw== X-Gm-Message-State: ALoCoQlnxoe9DKss7XVBrWBnmV6kxzAYJKhrLHYPk8TxumGKTjNPLd9iTg4dh3iw30bmrFQrFpffE7txf+DqNLhvbcecnzncOw== MIME-Version: 1.0 X-Received: by 10.202.210.151 with SMTP id j145mr95696495oig.114.1452658390119; Tue, 12 Jan 2016 20:13:10 -0800 (PST) Received: by 10.182.40.194 with HTTP; Tue, 12 Jan 2016 20:13:10 -0800 (PST) Reply-To: araujo@FreeBSD.org In-Reply-To: <20160113040225.GB42704@FreeBSD.org> References: <201601110721.u0B7LJHD048438@repo.freebsd.org> <20160111082634.GA7288@FreeBSD.org> <20160113040225.GB42704@FreeBSD.org> Date: Wed, 13 Jan 2016 12:13:10 +0800 Message-ID: Subject: Re: svn commit: r405766 - head/print/abcm2ps From: Marcelo Araujo To: Alexey Dokuchaev Cc: ports-committers , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 04:13:11 -0000 Hi, Please, would be good if you can send a patch. Best, 2016-01-13 12:02 GMT+08:00 Alexey Dokuchaev : > On Mon, Jan 11, 2016 at 08:26:34AM +0000, Alexey Dokuchaev wrote: > > On Mon, Jan 11, 2016 at 07:21:19AM +0000, Marcelo Araujo wrote: > > > New Revision: 405766 > > > URL: https://svnweb.freebsd.org/changeset/ports/405766 > > > > > > Log: > > > - Update to 8.10.0. > > > - USE_GCC yes. > > > > There are several problems with this commit. On the surface, it does not > > explain the reason for USE_GCC. Secondly, even with USE_GCC=yes it still > > does no build, due to "CC = gcc" line in the $wrksrc/Makefile. Also, the > > Sorry for confusion: apparently it builds with USE_GCC unless `lang/gcc48' > port is installed, which satisfies "depends on executable: gcc48 - found", > but doesn't install unversioned symlink (available since r402352 2015-11-24 > in `lang/gcc' itself -- older packages would also fail). > > That said, pulling GCC just because it provides `gcc' command looks bogus. > > > port does not uphold CFLAGS (and CC, obviously). > > > > Consider the following pseudo-patch: > > > > -USE_GCC= yes > > +MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}" > > If you prefer, I can send a real patch. > > ./danfe > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)