Date: Wed, 27 Jan 2021 10:43:23 +0100 From: Alexander Leidinger <Alexander@leidinger.net> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: freebsd-ports@freebsd.org Subject: Re: need a mentor/reviewer for a nfs-over-tls port Message-ID: <20210127104323.Horde.D1fpOMzUTJPMYRMxtZkqqx5@webmail.leidinger.net> In-Reply-To: <YQXPR0101MB09681677142B7BADA999EE47DDBB0@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format and has been PGP signed. --=_uDgULCN5oiw-WaIx_If8lFm Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Rick Macklem <rmacklem@uoguelph.ca> (from Wed, 27 Jan 2021=20=20 01:59:21=20+0000): > Hi, > > I am a src committer and have created a port for the > userland daemons needed to implement nfs-over-tls. > > It is my understanding that I can commit the port > once it is reviewed and approved by someone with a > ports commit bit. > --> So I am looking for a volunteer. It seems you are modifying the category-Makefile by hand. There is the=20= =20 script=20/usr/ports/Tools/scripts/addport which takes care about this=20=20 (and=20other things). This script will not modify your current tree, but=20= =20 checkout=20a temporary copy of the ports Mk directory and the category=20= =20 Makefile,=20make the modification there, and then commit it for you. You can run "addport -n -a -d nfs-over-tls" in the parent directory of=20= =20 the=20nfs-over-tls directory and it will do a test run with some checks=20= =20 without=20committing anything (because of the -n option). What it prints=20= =20 out=20is: WARN: Makefile: [14]: use a tab (not space) after a variable name WARN: Consider to set DEVELOPER=3Dyes in /etc/make.conf 0 fatal errors and 2 warnings found. I also tried (as root, so that I do not have to change the=20=20 WRKDIRPREFIX=20and such, and with the option "-m" it does not have svn=20= =20 access=20to the repo) "addport -n -at -m -d nfs-over-tls" but it fails=20= =20 fetching=20the openssl-3.0.0-alpha8.tar.gz, so a test-build (with=20=20 DEVELOPER=3DYES in make.conf) fails (my ports tree may need an=20=20 update...).=20This is supposed to detect pkg-plist issues. As we do not have KTLS in every release, I suggest to add a guard to=20=20 only=20build it on supported releases. See=20=20 https://docs.freebsd.org/en/books/porters-handbook/#porting-versions=20=20 and=20use IGNORE=3D... in such cases. Bye, Alexander. --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_uDgULCN5oiw-WaIx_If8lFm Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJgETW6AAoJEBINsJsD+NiG4rUQAJAn3wWxIv2/RtOQtD/e20LP Z6Kq9Q9N75pqN9mKLk1HyDDXL9S/cH/9OFmN77G9/Y2euY8taol+S9n9cL25VNag ZFCIkiyOXcDbD4hr6gcpErtravNg01uzNgo7XymfXpzfMrurBfX0QTbRLvNz+o1D aHCeFJKQsk//XP5OSx1t9Ru1/o0sY29yqLcXYVgcKGVI5t5juTPY6rSP0Pn9M3UB b1dwcH06UF+4mOHKZts4xMT4gNaq6MVrF6YGBItWMeSSrVwnAvrlpvfyrQ0MC660 /FzOmJ7xLWmlcbgD63dZZMBLg68yn0mRhtwdgJhztoDKkrgA03opCy1yQQWQm5ri NdD6MhrV14r9GxcXowsX7I3Sqeko6mpIs6bKwxeio7Z73TDvLTGvOmT/X2u6Ugve +xJv/yngj8c/seMGJJlaRUV81Qxw/Qi3EehSrKsaMcSYFX7C0+uMB9XHC/TKBTS6 4d9Ej2TPy+wavcH05s0E+vPS84+G8W2zHlkQR2OW8EryP3Gur1POYJKmWHV5jGrb Hx28wq08cJkzRYXLxvtmNX42zDAMEo6qwZSiZKdxNJxYt76lBNkHg8GvxczoJv+a po1f1pNyvIViHbCJI7ZBPqepD0eIiSZmTJLCDT8A4HM0nI6jqmbo+9y8BvOACRDY G6CPAhiNDJtneVv3x9Fz =jnfq -----END PGP SIGNATURE----- --=_uDgULCN5oiw-WaIx_If8lFm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210127104323.Horde.D1fpOMzUTJPMYRMxtZkqqx5>