From owner-cvs-src@FreeBSD.ORG Tue Sep 30 16:43:38 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B627A1065697; Tue, 30 Sep 2008 16:43:38 +0000 (UTC) (envelope-from rdivacky@lev.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 2F1238FC13; Tue, 30 Sep 2008 16:43:38 +0000 (UTC) (envelope-from rdivacky@lev.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id B816E9CB349; Tue, 30 Sep 2008 18:26:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R+BSbBe6LqhE; Tue, 30 Sep 2008 18:26:07 +0200 (CEST) Received: from lev.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 3BE749CB5B5; Tue, 30 Sep 2008 18:26:07 +0200 (CEST) Received: (from rdivacky@localhost) by lev.vlakno.cz (8.14.2/8.14.2/Submit) id m8UGQ6hZ047033; Tue, 30 Sep 2008 18:26:06 +0200 (CEST) (envelope-from rdivacky) Date: Tue, 30 Sep 2008 18:26:06 +0200 From: Roman Divacky To: Robert Watson Message-ID: <20080930162606.GA46594@freebsd.org> References: <200809271014.m8RAENka041457@repoman.freebsd.org> <48DE5C4F.8040807@micom.mng.net> <48DF2010.6030309@micom.mng.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, Ganbold , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2008 16:43:38 -0000 On Tue, Sep 30, 2008 at 05:19:57PM +0100, Robert Watson wrote: > > On Sun, 28 Sep 2008, Ganbold wrote: > > >>Indeed -- when an inpcb doesn't have a socket, ipfw will go ahead and do > >>a lookup for an inpcb even though one is passed down. I've committed a > >>change that short-circuits that and marks the credential lookup as > >>failed. Give it a try now? > > > >Thanks a lot, Robert, it was indeed simple effective fix. So far no crash > >:) With loads like pkg_adding emacs (which adds bunch of other packages) > >on plain CURRENT, downloading FreeBSD ISO with axel (20 simultaneous > >connection) through http works fine here. > > Good news. We'll want to keep an eye on this one as the 7.0 release cycle > progresses, and there may be other unexpected edge case problems from the > rwlock change. On the whole it seems to have been very successful, but the > view that -CURRENT doesn't receive a whole lot of stress testing is > reinforced... I think this is a little different case... I guess people are willing to test -CURRENT on their desktops etc. but not on "servers". ie. when you have immediate access to the machine you easily use -CURRENT but not on the remote server. Also, people don't tend to run firewalls on their desktops (as opposed to servers where they dont). This is why I think this bug slipped. Not that -CURRENT is so badly tested... roman