From nobody Mon Jun 9 20:28:30 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bGNmd235kz5yRmM; Mon, 09 Jun 2025 20:28:49 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bGNmd07j3z3Jqr; Mon, 09 Jun 2025 20:28:49 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-6077dea37easo5259972a12.3; Mon, 09 Jun 2025 13:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749500922; x=1750105722; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lwFbWXmpS1ByIMXxbfNkjJd1DdVLKdwjM7QiRJ5AZNc=; b=TsyvzAXgTkGCbZyDeNoCeJ4EXtowcQZBqs3aAtPuXRxqEoEj2g5yfuev0//UKQRNmv qSiaTIjn7vFFwEleCF7cBxBwxU011BPXF6OVfEyVVy9htbF3gg1akae0zOI/g+0f98n0 wbCrqGhlJXAVlMRfGtC1QDh1pfg4lCOdZSN5xnazNTy659gq/8IGkyhYxvPbqN2XLrII mHJDCSp1YzZ5fgfN3ntrMF8lktwESCJHy0PBNZDVKJeHcAABRB3Tj14+7IkFETyFaVfC UXp7RAEAUe//wdP2YrveRZSyUK584fDs+8w8/dVwAQJslL3pvaBtuQuCEr33zP1kfj8e eihQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749500922; x=1750105722; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwFbWXmpS1ByIMXxbfNkjJd1DdVLKdwjM7QiRJ5AZNc=; b=EBCqtWKPP85Ys6pfHSMHU2IeOMd+o2TRfZipvQM0I3xGksgPTtNPvLA6yBCRt3BG85 v5kS2jGfRMiq0Df8wanBYiX5Gw50pu1c8yIl/qT5xiHAJFlIk/EjW+sukFSjpTON1Zxv 1VzutrMp665G87SHdVJ5m9AAei1pUKBbNuNcYfp+kBiIuH+KYShOm6u6+N6c1IC1BALD lI2m1IaKmSCFkPSmu8clSVa8RlhwOyoOSnnB3mbhx0fT4iot/MOEkDIfai1V64p9lH5b bhRMyxbBL01MdML176tA0CdftIQfT0NiUkbG5LJ4a0QBtMxsFjT3euGZ7g9Nvy8TqO1M wizg== X-Forwarded-Encrypted: i=1; AJvYcCVtzrYWYmmcIQ3kOCNvvLiVzgCoYLuC1qWkAX6oDIbPSoKnUQcN1pan+DFjZHud5MC1EDg0wF49Q4Ujhkd9CTc=@freebsd.org, AJvYcCXTnC0bkA4xsF5c2EGfjEfpIplwch6EKCysKuRhozXFeDPDj9Dn+8Z1Mg1JlyOrYekW03tKwM3Srs2rxaUOBS4UInaq@freebsd.org, AJvYcCXhAaewS6WaB7OmGG/TnqcT/IPNpz/0F9WHZZdmrZZSKTMesxycMG2qkqLuwX7f4OFMARswQQ/P8GoYfSZ07UDgA3FQhYc=@freebsd.org X-Gm-Message-State: AOJu0YzFur1hUKRXhCuopkudSFb4nVF7VOnxFZ+YwYoiy+IN1tRGKbUS h3lsAQP8hLHk38bw1bmtKmQRWCRyX6HuP3LO7fGsBjOg961ge7e/AcVjdpGRQZ3AV35j7CaJntl eaBxfYdB+KJJSsG+fUI1QyfXR4XZACw9VU9orXw== X-Gm-Gg: ASbGncshMTK3NhJYJ9WO5Ox3JKE9O3oSYkpvAzR3pnYIT/cgk9ewkRkbuHfJTxP07oE +w2kUpbjSzDNRehxKR33JuIyRTgm/K4PAFFTexpwgUI/cMnyeb2ZuwPphORI66UUpeVuZVZqwIq xfVKqNlasTEa5e8lXZEQgU/EPmc77DOVqLRyK9RVI3llPTuZ4bXsvm3EeeMLHkC+tawxkPS38bl +Y= X-Google-Smtp-Source: AGHT+IGTdxVVos1hKz+5hfjcylVHUNoHJXizKXX6LWYIf4ziKnLfF8PA9+FwuVKGNCJUO6UC8OcXVxt0O/55cI2B1uY= X-Received: by 2002:a05:6402:2114:b0:607:d05f:7f14 with SMTP id 4fb4d7f45d1cf-607d05f86f2mr7326577a12.10.1749500921796; Mon, 09 Jun 2025 13:28:41 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Mon, 9 Jun 2025 13:28:30 -0700 X-Gm-Features: AX0GCFty8Fr9B2XKrnOpz57Ekuor3oAxNzYqz2bnP7_4WvB-Sw4L5-dXwk2wjIo Message-ID: Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. To: Konstantin Belousov Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bGNmd07j3z3Jqr X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Mon, Jun 9, 2025 at 5:10=E2=80=AFAM Konstantin Belousov wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > On Mon, Jun 09, 2025 at 04:59:15AM -0700, Rick Macklem wrote: > > On Mon, Jun 9, 2025 at 4:49=E2=80=AFAM Konstantin Belousov wrote: > > > > > > CAUTION: This email originated from outside of the University of Guel= ph. Do not click links or open attachments unless you recognize the sender = and know the content is safe. If in doubt, forward suspicious emails to ITh= elp@uoguelph.ca. > > > > > > On Mon, Jun 09, 2025 at 10:53:19AM +0000, Dag-Erling Sm=C3=B8rgrav wr= ote: > > > > The branch main has been updated by des: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D79d0f447465394fee8af= a833dbdeb1a5f3ed52c3 > > > > > > > > commit 79d0f447465394fee8afa833dbdeb1a5f3ed52c3 > > > > Author: Dag-Erling Sm=C3=B8rgrav > > > > AuthorDate: 2025-06-09 10:52:21 +0000 > > > > Commit: Dag-Erling Sm=C3=B8rgrav > > > > CommitDate: 2025-06-09 10:52:21 +0000 > > > > > > > > rpcbind: Ensure krpc is present. > > > > > > > > MFC after: 1 week > > > > Reviewed by: rmacklem, glebius > > > > Differential Revision: https://reviews.freebsd.org/D50627 > > > > --- > > > > usr.sbin/rpcbind/rpcbind.c | 35 +++++++++++++++++++++-------------= - > > > > 1 file changed, 21 insertions(+), 14 deletions(-) > > > > > > > > diff --git a/usr.sbin/rpcbind/rpcbind.c b/usr.sbin/rpcbind/rpcbind.= c > > > > index 1397a0222396..622e954f903b 100644 > > > > --- a/usr.sbin/rpcbind/rpcbind.c > > > > +++ b/usr.sbin/rpcbind/rpcbind.c > > > > @@ -39,34 +39,38 @@ > > > > * > > > > */ > > > > > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > +#include > > > > +#include > > > > +#include > > > > #include > > > > -#include > > > > #include > > > > #include > > > > +#include > > > > +#include > > > > #include > > > > +#include > > > > + > > > > #include > > > > #include > > > > #ifdef PORTMAP > > > > #include > > > > #endif > > > > #include > > > > + > > > > #include > > > > +#include > > > > +#include > > > > #include > > > > +#include > > > > #include > > > > +#include > > > > #include > > > > #include > > > > -#include > > > > #include > > > > -#include > > > > -#include > > > > -#include > > > > -#include > > > > #include > > > > -#include > > > > +#include > > > > +#include > > > > + > > > > #include "rpcbind.h" > > > > > > > > /* Global variables */ > > > > @@ -148,12 +152,15 @@ main(int argc, char *argv[]) > > > > > > > > update_bound_sa(); > > > > > > > > + /* Ensure krpc is loaded */ > > > > + if (modfind("krpc") < 0 && kldload("krpc") < 0) > > > > + err(1, "krpc"); > > > Why does rpcbind need krpc mod? > > > I understand that today most uses of Sun RPC are coming from nfs stuf= f. > > > But it is still not the only application. E.g., NIS is still there. > > > > I asked the same thig during review. It appears that the requirement > > is based on the recent change to using RPC over netlink instead > > of a unix domain socket, done by glebius@. > > For what? > Take for instance a machine participating in NIS domain but not doing NFS= . My vague recollection (I'll admit I cannot be bothered looking at the older code) is that rpcbind would accept queries on a AF_LOCAL (unix domain) socket for local RPC processes. glebius@ does not want RPCs to be done over AF_LOCAL sockets (he would have to explain why), so he created an RPC layer in the krpc for netlink as= an alternative and converted all utilities that were doing RPCs over AF_LOCAL sockets to use it. --> Since some part of the netlink conversion is in the krpc, the krpc is n= eeded for any RPC program that wants to use netlink, as I understand it. (The other RPC utilities that used to do RPCs over AF_LOCAL are all N= FS related, so the krpc being loaded is a given.) For any more info than the above, glebius@ will have to explain it. rick