From owner-cvs-all@FreeBSD.ORG Sat Nov 5 00:33:55 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D02FB16A41F; Sat, 5 Nov 2005 00:33:55 +0000 (GMT) (envelope-from peter@wemm.org) Received: from daintree.corp.yahoo.com (daintree.corp.yahoo.com [216.145.52.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4B2E43D64; Sat, 5 Nov 2005 00:33:48 +0000 (GMT) (envelope-from peter@wemm.org) Received: by daintree.corp.yahoo.com (Postfix, from userid 2154) id 661A6197A8; Fri, 4 Nov 2005 16:33:48 -0800 (PST) From: Peter Wemm To: Ceri Davies Date: Fri, 4 Nov 2005 16:33:46 -0800 User-Agent: KMail/1.8.2 References: <200511040416.jA44GiAG061102@repoman.freebsd.org> <20051104071858.GT63539@ip.net.ua> <20051104093436.GI29387@submonkey.net> In-Reply-To: <20051104093436.GI29387@submonkey.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511041633.47778.peter@wemm.org> Cc: Warner Losh , src-committers@freebsd.org, Ruslan Ermilov , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/config configvers.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2005 00:33:56 -0000 On Friday 04 November 2005 01:34 am, Ceri Davies wrote: > On Fri, Nov 04, 2005 at 09:18:58AM +0200, Ruslan Ermilov wrote: > > On Fri, Nov 04, 2005 at 04:16:44AM +0000, Warner Losh wrote: > > > imp 2005-11-04 04:16:44 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > usr.sbin/config configvers.h > > > Log: > > > since nocpu isn't used in the kernel config base, we don't need > > > to bump the version. Peter Wemm, John Baldwin and I hammered > > > this out after the last time I needlessly incremented the > > > version. > > > > > > Revision Changes Path > > > 1.38 +1 -1 src/usr.sbin/config/configvers.h > > > > Our users wanted to *use* the "nocpu" directive in their configs > > that are based on GENERIC (GENERIC is included), hence I bumped > > config(8). Otherwise, one day some would scream that "nocpu" > > doesn't work for them, because they're using the older version > > of config(8). > > I'd agree that the Makefiles don't need to be bumped, as they don't > actually require the new config, but config has new functionality and > the version should probably be bumped in the binary. The reason for configvers in the first place was that config(8) didn't fail for many error conditions at all. It would create a bogus kernel build environment even though a parser change caused hundreds of syntax errors. This was a real problem because 'make buildkernel' had become all the 'in' thing to do, and people were getting hosed because buildkernel/installkernel would quite happily install a bogus kernel after generating hundreds of lines of error messages. The victim would be none the wiser because the config output would be lost in the noise of the make output. config was originally written to be used interactively and the results read, not run from a make script. Over time, config was fixed to correctly return error codes for parser problems, and the syntax evolved so that errors were more likely to be detected. These days we generally don't need to bump configvers because syntax changes are correctly detected. configvers should only be bumped if they are NOT detected, or if the interface between /sys/conf/* and /usr/sbin/config has changed. Adding 'nocpu' does not require a configvers bump. An older config(8) will correctly fail with a syntax error if it is exposed to a newer 'nocpu' keyword. Needlessly bumping configvers is harmful because it disrupts users and developers. config should NOT be made to fail just because it is out of sync with 'nocpu' support whennocpu isn't used. That would be just silly. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5