From nobody Wed Apr 22 21:08:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1BfW2hT4z6bKyd for ; Wed, 22 Apr 2026 21:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1BfW0bTYz3lZZ for ; Wed, 22 Apr 2026 21:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776892131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y19KvymqiV05smGhlnYet3hp1QRiEOZYDPt4Svf62JQ=; b=vOIAEadEgFX5WKDYEcb4ESDok0cVoQSuHziIb0aIZqxb7IkQLPuIGSLPrqR9u5hyMUhwuF Ca1yLyDYn0jlnJvbmS90Hjg/+dgrzaDtavCjsru5G/6V+jOngleecjeRMYBzrLEuIomv1/ XHp1MuGdPFLb5iBZ3f6pKnYDKLQVWXu1w//r++GVUGb97LSmVrfw74IYJV2K+S00tLK5dn r1O1yYQ5Ss2mCeljZehsztXNOMzz1EJMIiSpnTa3GsclsK9zRRbDP9mrzsdnVjSsvWNEEe IrbRdf2SFpSmrMUuthFLPjgooRHVkjVctgOMM5ofG/jaIxTS94co8H+K5xEdHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776892131; a=rsa-sha256; cv=none; b=Wo7Rjy++Hnpl7OJRIbh4D6Ei5p8SKSwISyMlKEMcQ82HuY5nidjkN/Rr6ugrcEJTFhB4a+ OXG4O9jPZr+gcmu7O9DXX7lJyrc7az01uB3zJ7Fn3jV5ZG30FY6TjkxbCx+eVqS/vuUTdj JZwFeXBXOiACS+2ELtHz+A+cScMa1f7NVEdLrn0Sb13y4FcccIy7u3Ecg/c35v9siHD48F KLgmFd+Je3UfURww8baWiw1f32ChuVvV/BFoozBYlL03cBymJ8rJJ0Ujk1C+xNIqiH6dLa LesPuVXMiqH4WJBoNGScAimcO9BaMMF5WXCuUpIoZTDFHlrguLTikOe0j53D/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776892131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y19KvymqiV05smGhlnYet3hp1QRiEOZYDPt4Svf62JQ=; b=T+pjVXp4BxJ0gor5ttVhWI3bHPxxS6yWjdfWW9jE8Jd3+l+8c28gVz1CY26dV24LAuzdGz ZNfTG6L/bEv/fz2b+tHVu4urxpXgWtsZ+Cr69FX2MPEQ3c3xPNNaJvTLg3ZNseGBPwpCx5 Y29HGkTcd+gWc/0l1X8HhSATSsqwj0cmNrOzhXkdsKaVV8quI6flfCLcaoFtyhtDYpoZHb iNDwl4VqWmOVmvukFCqyx4vMOrJIT7LH8nSNGJlhlwLpvXhn5Awi8VVGBdb1ZeGAtWScx4 75sjreKY4ts+9zTnQljJBq4NFPcPJHJVs1EjZe18BdkjeZyEMylMAGpRw4CCXw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g1BfW018xznjY for ; Wed, 22 Apr 2026 21:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 303bd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 21:08:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Bjoern A. Zeeb Subject: git: d81388696014 - stable/15 - rtw89: add a warn about beacon_int or dtim_period being 0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d81388696014dbfe21e434e1b660152bbbb41b35 Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 21:08:50 +0000 Message-Id: <69e938e2.303bd.2bda0977@gitrepo.freebsd.org> The branch stable/15 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=d81388696014dbfe21e434e1b660152bbbb41b35 commit d81388696014dbfe21e434e1b660152bbbb41b35 Author: Bjoern A. Zeeb AuthorDate: 2026-04-17 02:40:03 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-04-22 20:57:07 +0000 rtw89: add a warn about beacon_int or dtim_period being 0 While after the changes to LinuxKPI 802.11 we should never be assoc and not have dtim_period set, we have seen before that this could happen. Add a WARN as that will help debugging the following DIV 0. Sponsored by: The FreeBSD Foundation (cherry picked from commit 99bbfb77e3c395805fe0a7f19006c5c29136f9fc) --- sys/contrib/dev/rtw89/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/contrib/dev/rtw89/core.c b/sys/contrib/dev/rtw89/core.c index aeaf1c8f80c5..1dee73a62f98 100644 --- a/sys/contrib/dev/rtw89/core.c +++ b/sys/contrib/dev/rtw89/core.c @@ -2838,6 +2838,10 @@ static void rtw89_core_bcn_track_assoc(struct rtw89_dev *rtwdev, dtim = bss_conf->dtim_period; rcu_read_unlock(); +#if defined(__FreeBSD__) + WARN(beacon_int == 0 || dtim == 0, "period %u / beacon_int %u / dtim %u\n", + period, beacon_int, dtim); +#endif beacons_in_period = period / beacon_int / dtim; bcn_intvl_us = ieee80211_tu_to_usec(beacon_int);