From owner-p4-projects  Tue Mar 19 12: 1:38 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A69C837B405; Tue, 19 Mar 2002 12:00:39 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by hub.freebsd.org (Postfix) with ESMTP id 7BC4837B41A
	for <perforce@FreeBSD.org>; Tue, 19 Mar 2002 12:00:22 -0800 (PST)
Received: (qmail 24699 invoked from network); 19 Mar 2002 20:00:21 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <perforce@FreeBSD.org>; 19 Mar 2002 20:00:21 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2JK0pv58685;
	Tue, 19 Mar 2002 15:00:51 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020319150024.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20020319194600.B2BB33810@overcee.wemm.org>
Date: Tue, 19 Mar 2002 15:00:24 -0500 (EST)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@wemm.org>
Subject: Re: PERFORCE change 7933 for review
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 19-Mar-2002 Peter Wemm wrote:
> John Baldwin wrote:
>> 
>> On 19-Mar-2002 Peter Wemm wrote:
>> > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7933
>> > 
>> > Change 7933 by peter@peter_overcee on 2002/03/19 01:29:12
>> > 
>> >       add the ia64 IO tag, and add a #error to catch this in future.
>> > 
>> > Affected files ...
>> > 
>> > ... //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 edit
>> > 
>> > Differences ...
>> > 
>> > ==== //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 (text+ko) ====
>> > 
>> > @@ -159,6 +159,10 @@
>> >       tag = I386_BUS_SPACE_IO;
>> >  #elif defined(__alpha__)
>> >       tag = busspace_isa_io;
>> > +#elif defined(__ia64__)
>> > +     tag = IA64_BUS_SPACE_IO;
>> > +#else
>> > +#error "define tag!"
>> >  #endif
>> >  
>> >  #if notyet
>> 
>> Maybe there should be a MD macro to define what the appropriate bus tag is?
> 
> Actually, this should use the proper API's instead of hacking around like
> this.

Fair enough, wasn't sure if it could be using bus_alloc_resource() like a Good
Little Device Driver or not.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message