From owner-p4-projects@FreeBSD.ORG  Sat Jun 13 10:47:21 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 393761065673; Sat, 13 Jun 2009 10:47:21 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ED294106566B
	for <perforce@FreeBSD.org>; Sat, 13 Jun 2009 10:47:20 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id DB12A8FC0A
	for <perforce@FreeBSD.org>; Sat, 13 Jun 2009 10:47:20 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5DAlKrY004717
	for <perforce@FreeBSD.org>; Sat, 13 Jun 2009 10:47:20 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5DAlK1H004711
	for perforce@freebsd.org; Sat, 13 Jun 2009 10:47:20 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Date: Sat, 13 Jun 2009 10:47:20 GMT
Message-Id: <200906131047.n5DAlK1H004711@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zhaoshuai@FreeBSD.org using -f
From: Zhao Shuai <zhaoshuai@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 164258 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2009 10:47:22 -0000

http://perforce.freebsd.org/chv.cgi?CH=164258

Change 164258 by zhaoshuai@zhaoshuai on 2009/06/13 10:46:37

	find a bug when testing fifo select.

Affected files ...

.. //depot/projects/soc2009/fifo/fifo_test/functionality/select.c#3 edit

Differences ...

==== //depot/projects/soc2009/fifo/fifo_test/functionality/select.c#3 (text+ko) ====

@@ -1,7 +1,10 @@
 /*
  * Basic FIFO select test.
  *
- * 1. select on read descriptor - OK
+ * 1. select on read descriptor - XXX
+ *	if writer exits before us, "top" shows that we are busy
+ *	consuming CPU rather than sleep.
+ *
  * 2. select on write descriptor - OK
  */
 
@@ -20,11 +23,9 @@
 
 	FD_ZERO(&rset);
 	FD_ZERO(&wset);
+	fd = open(FIFO_PATH, O_RDONLY | O_NONBLOCK);
 	/*
-	fd = open(FIFO_PATH, O_RDONLY | O_NONBLOCK);
-	*/
 	fd = open(FIFO_PATH, O_WRONLY | O_NONBLOCK);
-	/*
 	fd = open(FIFO_PATH, O_WRONLY); 
 	*/
 	if (fd < 0) {
@@ -35,24 +36,24 @@
 		FD_SET(fd, &rset);
 		FD_SET(fd, &wset);
 
+		ret = select(fd+1, &rset, NULL, NULL, NULL);
 		/*
-		ret = select(fd+1, &rset, NULL, NULL, NULL);
+		ret = select(fd+1, NULL, &wset, NULL, NULL);
 		*/
-		ret = select(fd+1, NULL, &wset, NULL, NULL);
 		if (ret > 0) {
-			/*
 			if (FD_ISSET(fd, &rset)) {
 				n = read(fd, buf, BUF_SIZE);
 				printf("%s", buf);
 				memset(buf, 0, n);
 			}
-			*/
+			/*
 			if (FD_ISSET(fd, &wset)) {
 				n = read(0, buf, BUF_SIZE);
 				if (n <= 0)
 					return (0);
 				write(fd, buf, n);
 			}
+			*/
 		} else if (ret < 0) { /* select error */
 			perror("select error");
 			return (2);