From owner-freebsd-rc@FreeBSD.ORG Sat Nov 17 23:01:09 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 77B62493; Sat, 17 Nov 2012 23:01:09 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 5E99F8FC15; Sat, 17 Nov 2012 23:01:08 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qAHN0qtY088915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 18 Nov 2012 08:01:02 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qAHN0n9e050687; Sun, 18 Nov 2012 08:00:51 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 18 Nov 2012 07:59:56 +0900 (JST) Message-Id: <20121118.075956.2090347175828215059.hrs@allbsd.org> To: crees@FreeBSD.org Subject: Re: bin/165477: [rc] dhclient is run twice From: Hiroki Sato In-Reply-To: <201211021111.qA2BBHEi008211@freefall.freebsd.org> References: <201211021111.qA2BBHEi008211@freefall.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 18 Nov 2012 08:01:02 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org, wblock@FreeBSD.org, bug-followup@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2012 23:01:09 -0000 ----Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)-- Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Nov_18_07_59_56_2012_546)--" Content-Transfer-Encoding: 7bit ----Next_Part(Sun_Nov_18_07_59_56_2012_546)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit crees@freebsd.org wrote in <201211021111.qA2BBHEi008211@freefall.freebsd.org>: cr> Synopsis: [rc] dhclient is run twice cr> cr> State-Changed-From-To: open->feedback cr> State-Changed-By: crees cr> State-Changed-When: Fri Nov 2 11:11:17 UTC 2012 cr> State-Changed-Why: cr> Please try out the patch at cr> http://www.bayofrum.net/~crees/patches/165477.diff to devd.conf. It cr> does the "right thing", so let me know if it stops your problem. I think it is safe to remove the warning message when rc_quiet=YES. What do you think about the attached patch? -- Hiroki ----Next_Part(Sun_Nov_18_07_59_56_2012_546)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rc.subr_quiet_20121118-1.diff" Index: etc/rc.subr =================================================================== --- etc/rc.subr (revision 243184) +++ etc/rc.subr (working copy) @@ -704,7 +704,9 @@ start) if [ -z "$rc_fast" -a -n "$rc_pid" ]; then - echo 1>&2 "${name} already running? (pid=$rc_pid)." + if [ ! -z "$rc_quiet" ]; then + echo 1>&2 "${name} already running? (pid=$rc_pid)." + fi return 1 fi ----Next_Part(Sun_Nov_18_07_59_56_2012_546)---- ----Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCoFuwACgkQTyzT2CeTzy1usgCgmqzn4/7Yhr0+fwxOPHqOXW07 FzUAoLQ/xwkyWXICEt8ptmJZrTq6icRA =etD7 -----END PGP SIGNATURE----- ----Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)----