From owner-cvs-all Sun Sep 29 23:41:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F13F837B401; Sun, 29 Sep 2002 23:41:12 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7341943E3B; Sun, 29 Sep 2002 23:41:12 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id g8U6fBCY004050; Sun, 29 Sep 2002 23:41:11 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.5/Submit) id g8U6fB5i004049; Sun, 29 Sep 2002 23:41:11 -0700 (PDT) Date: Sun, 29 Sep 2002 23:41:11 -0700 From: "David O'Brien" To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aic7xxx/aicasm aicasm_symbol.c Message-ID: <20020930064111.GA1082@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200209300247.g8U2lNAA078034@freefall.freebsd.org> <20020930155132.O44572-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020930155132.O44572-100000@gamplex.bde.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Sep 30, 2002 at 04:12:58PM +1000, Bruce Evans wrote: > On Sun, 29 Sep 2002, David E. O'Brien wrote: > > > obrien 2002/09/29 19:47:23 PDT > > > > Modified files: > > sys/dev/aic7xxx/aicasm aicasm_symbol.c > > Log: > > Use fcntl.h from inside /sys. > > > > Reviewd by: scottl > > > > Revision Changes Path > > 1.21 +1 -1 src/sys/dev/aic7xxx/aicasm/aicasm_symbol.c > > This is sort of backwards. aicasm runs on the host, so it should > include only host headers. Howver, the change should be only a style > bug in practice, since fcntl.h is a link to sys/fcntl.h and there > shouldn't be any -I paths to /sys in the build of aicasm. There > seems to be a problem only with the directory: there is a > -I path to the kernel build directory and that directory has a > machine symlink in it, so aicasm is built with an inconsistent set > of includes in kernels. Don't know what to say, other than it bit me a few months ago aicasm it was reaching outside of /sys back when the low-down "not to be included directly" headers moved around. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message